[Quek Wei Ping] Duke Increments #342
Conversation
Add toolVersion block in to Gradle code sample to prevent errors.
Change file mode on `gradle` to be executable (nus-cs2103-AY1920S1#9)
|
Code looks good and neat! |
There was a problem hiding this comment.
I would recommend to git ignore the *.class file since those file will most likely be changed everytime you change your java code. Hence, it will be more convenient to just ignore them. Moreover, the bytecode will no longer be used when you have automated your build with gradle.
Overall, you have done a great job on the project. In fact, you have prepared a lot of test cases. Therefore, you should be able to refactor your code easily without causing regeression.
src/main/java/Deadline.java
Outdated
| return String.format("[D][%s] %s(by: %s)", getStatusIcon(), | ||
| getDescription(), getTime()); | ||
| } | ||
| } |
There was a problem hiding this comment.
I would suggest adding a new line at the end of each file. Although, it is not in the coding standard, but usually git complains when there is no new line.
src/main/java/Duke.java
Outdated
| + "| |_| | |_| | < __/\n" | ||
| + "|____/ \\__,_|_|\\_\\___|\n"; | ||
| System.out.println("Hello from\n" + logo); | ||
| List<String> start = new ArrayList<>(); |
There was a problem hiding this comment.
Duke.java seems to be too complicated since it contains too much logic inside. Therefore, I recommend you to do some refactoring in the code so that the code be more mantainable. Try to refer to Week3's Project on A-MoreOOP increments, it really helps me in improving my code design.
src/main/java/ToDo.java
Outdated
| } | ||
|
|
||
| public static ToDo createToDo(String [] tokens) { | ||
| StringBuilder builder = new StringBuilder(); |
There was a problem hiding this comment.
You can take a look at String.join method to make the code simpler.
Implment Save and Refactor
Implement Dates and Times
Write JavaDoc
Implement Find Command
Try out rebase
Branch A-Assertions
A-CodeQuality
No description provided.