Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing deadline of task from json #2107

Open
nus-pe-bot opened this issue Nov 15, 2019 · 1 comment
Open

Editing deadline of task from json #2107

nus-pe-bot opened this issue Nov 15, 2019 · 1 comment

Comments

@nus-pe-bot
Copy link

When I edit ddl of a task to 9999-12-12, it still gets imported into the app, although it has passed the training planb's end date.

Screenshot 2019-11-15 at 17.11.29.png


[original: nus-cs2103-AY1920S1/pe-interim#2116]
@jiayushe
Copy link
Contributor

jiayushe commented Nov 16, 2019

Team's Response

A normal user would not purposedly change a task's end date directly through JSON.

According to Prof Damith's reply on forum,

In the context of the PE, it is OK for an app to not recover from deliberate sabotage attempts by the user. But the app should at least fail gracefully for potential user mistakes e.g., deleting a config/data file by mistake.

Changing a task's end date to an invalid one directly through JSON is obviously a deliberate sabotage attempt, instead of potential user mistasks, hence it is not accepted as a bug for PE.

Severity is downgraded to Low since it does not affect any normal user.

Type is changed to FeatureFlaw since we do not expect user to sabotage JSON file directly.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants