Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG Page 24 lifeline does not end after cross #5778

Open
nus-pe-bot opened this issue Nov 11, 2022 · 1 comment
Open

DG Page 24 lifeline does not end after cross #5778

nus-pe-bot opened this issue Nov 11, 2022 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 11, 2022

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.



There are still lifeline under the cross. I know this may be a restriction of plantUML, but can explicitly state it.

image.png


[original: nus-cs2103-AY2223S1/pe-interim#5771] [original labels: severity.VeryLow type.DocumentationBug]
@chngchngchng
Copy link
Contributor

Team's Response

Screenshot 2022-11-14 at 4.13.37 PM.png

We stated this in an earlier diagram but agree that it might be prudent to put a small disclaimer in all diagrams where a similar issue occurs.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants