Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No whitespace between t/ and other inputs for edit is not allowed #5578

Open
nus-pe-bot opened this issue Apr 19, 2024 · 1 comment
Open

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 19, 2024

image.png

As not including any information to tags should remove all tags of the contact, if another input for the contact to be edited is followed without whitespace, it is better to accept it.


[original: nus-cs2103-AY2324S2/pe-interim#5570] [original labels: type.FunctionalityBug severity.Medium]
@ziiqii
Copy link
Contributor

ziiqii commented Apr 20, 2024

Team's Response

image.png

Firstly in our UG, the command format for edit has shown explicitly that there must be whitespaces between fields.

image.png

Secondly, we have already specified that the if the user wants to remove all tags, there must not be tags after it. However in the screenshot, the tester input "t/e/[email protected]". In this case, the full "e/[email protected]" is treated as the tag the tester is trying to input, which is the expected behavior of our app.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants