Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reservation is not logical #5583

Open
nus-pe-bot opened this issue Apr 19, 2024 · 1 comment
Open

Reservation is not logical #5583

nus-pe-bot opened this issue Apr 19, 2024 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 19, 2024

Currently, if the I want to take notes about reservations, I should use the index of contacts which contains not only the name and phone number but also the email and address to add reservations. However, it is very strange that the restaurant owners have the customer's real address and email address. Also, they may not save all the customers' contact information privately.
Thus, it would be better

  1. make address and email optional(or maybe not optional only for employee and supplier)
  2. can use "rsv" command with name, phone number, d, t, p, like add instead of using the already saved contacts by using index.

[original: nus-cs2103-AY2324S2/pe-interim#5576] [original labels: severity.Medium type.FeatureFlaw]
@ziiqii
Copy link
Contributor

ziiqii commented Apr 20, 2024

Team's Response

This was already captured in our planned enhancements.

image.png

Having less compulsory fields makes it much easier to add a contact.
This in turn makes it easier to make a reservation for a contact, without requiring the customer's real address and email address like the reviewer has suggested.

Reviewer's second suggestion is a fundamental change to the functionality of the rsv command, and is not relevant to our feature.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants