+## Product Name: AgentConnect
+
+Target User: Insurance agents tracking their clients
+
+Value proposition: provides quick and efficient access to client details, tailored for insurance agents who need a streamlined interface to manage contacts, track policy updates, and schedule client follow-ups.
+
+
+
+### Mant Koh En Wei
+
+
[[homepage](http://www.comp.nus.edu.sg/~damithch)]
-[[github](https://github.com/johndoe)]
-[[portfolio](team/johndoe.md)]
+[[github](https://github.com/m-kew)]
+[[portfolio](team/m-kew.md)]
-* Role: Project Advisor
+* Role: Developer
+* Responsibilities: Team Lead
-### Jane Doe
-
-[[github](http://github.com/johndoe)]
-[[portfolio](team/johndoe.md)]
+### Denon Chong
-* Role: Team Lead
-* Responsibilities: UI
+
+
+
+[[github](https://github.com/ssirmentos)]
+[[portfolio](team/ssirmentos.md)]
+
+
+* Role: Developer
+* Responsibilities: Documentation
-### Johnny Doe
+### Ong Juan Wen
-
+
-[[github](http://github.com/johndoe)] [[portfolio](team/johndoe.md)]
+[[github](http://github.com/the0nlyjuan)] [[portfolio](team/the0nlyjuan.md)]
* Role: Developer
-* Responsibilities: Data
+* Responsibilities: Code Quality
-### Jean Doe
+### Edwin Wong
-
+
-[[github](http://github.com/johndoe)]
-[[portfolio](team/johndoe.md)]
+[[github](http://github.com/Edwin1022)]
+[[portfolio](team/edwinwong.md)]
* Role: Developer
* Responsibilities: Dev Ops + Threading
-### James Doe
+### Aw Ming Yi
-
+
-[[github](http://github.com/johndoe)]
-[[portfolio](team/johndoe.md)]
+[[github](http://github.com/MingYiAw)]
+[[portfolio](team/mingyiaw.md)]
* Role: Developer
* Responsibilities: UI
diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md
index 743c65a49d2..78b171117f6 100644
--- a/docs/DeveloperGuide.md
+++ b/docs/DeveloperGuide.md
@@ -91,9 +91,9 @@ Here's a (partial) class diagram of the `Logic` component:
-The sequence diagram below illustrates the interactions within the `Logic` component, taking `execute("delete 1")` API call as an example.
+The sequence diagram below illustrates the interactions within the `Logic` component, taking `execute("delete John Doe")` API call as an example.
-
+
+
+
### Model component
**API** : [`Model.java`](https://github.com/se-edu/addressbook-level3/tree/master/src/main/java/seedu/address/model/Model.java)
@@ -155,11 +160,11 @@ Classes used by multiple components are in the `seedu.address.commons` package.
This section describes some noteworthy details on how certain features are implemented.
-### \[Proposed\] Undo/redo feature
+### Undo/redo feature
-#### Proposed Implementation
+#### Implementation
-The proposed undo/redo mechanism is facilitated by `VersionedAddressBook`. It extends `AddressBook` with an undo/redo history, stored internally as an `addressBookStateList` and `currentStatePointer`. Additionally, it implements the following operations:
+The undo/redo mechanism is facilitated by `VersionedAddressBook`. It extends `AddressBook` with an undo/redo history, stored internally as an `addressBookStateList` and `currentStatePointer`. Additionally, it implements the following operations:
* `VersionedAddressBook#commit()` — Saves the current address book state in its history.
* `VersionedAddressBook#undo()` — Restores the previous address book state from its history.
@@ -228,16 +233,16 @@ The following activity diagram summarizes what happens when a user executes a ne
**Aspect: How undo & redo executes:**
-* **Alternative 1 (current choice):** Saves the entire address book.
+* **Current Implementation:** Saves the entire address book.
* Pros: Easy to implement.
* Cons: May have performance issues in terms of memory usage.
-* **Alternative 2:** Individual command knows how to undo/redo by
+* **Alternative 1:** Individual command knows how to undo/redo by
itself.
* Pros: Will use less memory (e.g. for `delete`, just save the person being deleted).
* Cons: We must ensure that the implementation of each individual command are correct.
-_{more aspects and alternatives to be added}_
+
### \[Proposed\] Data archiving
@@ -262,71 +267,291 @@ _{Explain here how the data archiving feature will be implemented}_
**Target user profile**:
-* has a need to manage a significant number of contacts
-* prefer desktop apps over other types
+* Insurance agents tracking their clients
+* Has a need to manage and track a significant number of clients with detailed insurance-related information.
+* Frequently engages with clients, requiring automated reminders for appointments, renewals, and follow-ups.
+* Prefers desktop apps that support fast and efficient data management over mobile or web alternatives.
* can type fast
* prefers typing to mouse interactions
* is reasonably comfortable using CLI apps
-**Value proposition**: manage contacts faster than a typical mouse/GUI driven app
+**Value proposition**: provides quick and efficient access to client details, tailored for insurance agents who need a streamlined interface to manage contacts, track policy updates, and schedule client follow-ups.
+
### User stories
Priorities: High (must have) - `* * *`, Medium (nice to have) - `* *`, Low (unlikely to have) - `*`
-| Priority | As a … | I want to … | So that I can… |
-| -------- | ------------------------------------------ | ------------------------------ | ---------------------------------------------------------------------- |
-| `* * *` | new user | see usage instructions | refer to instructions when I forget how to use the App |
-| `* * *` | user | add a new person | |
-| `* * *` | user | delete a person | remove entries that I no longer need |
-| `* * *` | user | find a person by name | locate details of persons without having to go through the entire list |
-| `* *` | user | hide private contact details | minimize chance of someone else seeing them by accident |
-| `*` | user with many persons in the address book | sort persons by name | locate a person easily |
+| Priority | As a … | I want to … | So that I can… |
+|----------|---------|----------------------------------------------------|-------------------------------------------------------------------------------|
+| `* * *` | user | add clients to my existing addressbook | store their contacts and respective information |
+| `* * *` | user | know if client has been added successfully | so that I can proceed with the next steps or take corrective action if needed |
+| `* * *` | user | mark a client’s insurance payment as paid | keep their due date up to date and know when they’ve fully paid || `* * *` | user | update existing client details | keep their information up to date. |
+| `* * *` | user | record client's email address | contact them through email |
+| `* * *` | user | sort clients by renewal dates | prioritize my outreach efforts |
+| `* * *` | user | remove clients should they change insurance agents | |
+| `* * *` | user | know when was my client's last appointment | track when to follow up |
+| `* * *` | user | know when is my client's birthday | reach out to build rapport |
+| `* * *` | user | know when is my client's next insurance payment | so that I can keep track of client's payment |
-*{More to be added}*
### Use cases
-(For all use cases below, the **System** is the `AddressBook` and the **Actor** is the `user`, unless specified otherwise)
+(For all use cases below, the **System** is the `AgentConnect` and the **Actor** is the `user`, unless specified otherwise)
+
+**Use case: Add a person**
+
+**MSS**
+
+1. User adds a new person by entering the command with name, phone number, email, address, insurance type, and appointment dates.
+2. AgentConnect validates the input.
+3. AgentConnect adds the new person with all the details provided.
+4. AgentConnect shows a success message confirming the person has been added.
+
+ Use case ends.
+
+
+**Extensions**
+
+* 2a. Some fields are invalid (e.g., name, phone, email).
+ * 2a1. AgentConnect shows an error message for the invalid fields.
+ * 2a2. User corrects the fields and resubmits the command.
+ * Use case resumes from step 2.
+
+* 2b. Duplicate person detected (same name + address).
+ * 2b1. AgentConnect shows a warning message about the duplicate entry.
+ * 2b2. User modifies either the name, address, or both fields, then resubmits the command
+ * Use case resumes at step 2 if user decides to proceed
+
**Use case: Delete a person**
**MSS**
-1. User requests to list persons
-2. AddressBook shows a list of persons
-3. User requests to delete a specific person in the list
-4. AddressBook deletes the person
+1. User enters the delete command with the Index or Name of the person to be deleted.
+2. AgentConnect validates the input.
+3. AgentConnect confirms the deletion request by showing a confirmation dialog with the Name of the person to be deleted.
+4. AgentConnect deletes the contact and shows a success message.
Use case ends.
**Extensions**
+* 2a. Contact not found (Invalid Index or Name).
+ * 2a1. AgentConnect shows an error message indicating Index or Name is invalid.
+ * 2a2. User can retry with a valid Index or valid Name.
+ * Use case resumes from step 2.
+* 2b. Duplicate Person detected (same name)
+ * 2b1. AgentConnect updates the list in the GUI with the duplicates and prompts the user to delete by index.
+ * 2b2. User selects the index to delete the duplicate person.
+ * 2b3. Use case resumes from step 3.
+
+**Use case: Delete a policy**
+
+**MSS**
-* 2a. The list is empty.
+1. User enters the delete command with the index of the client and the index of the policy to be deleted.
+2. AgentConnect validates the input.
+3. AgentConnect deletes the policy and shows a success message.
- Use case ends.
+ Use case ends.
-* 3a. The given index is invalid.
+**Extensions**
+* 2a. Client not found (Invalid Index).
+ * 2a1. AgentConnect shows an error message indicating Index is invalid.
+ * 2a2. User can retry with a valid Index.
+ * Use case resumes from step 2.
+* 2b. Policy not found (Invalid policy Index).
+ * 2b1. AgentConnect shows an error message indicating policy Index is invalid.
+ * 2b2. User can retry with a valid policy Index.
+ * Use case resumes from step 2.
- * 3a1. AddressBook shows an error message.
+**Use case: Undo a Command**
- Use case resumes at step 2.
+**MSS**
-*{More to be added}*
+1. User enters the undo command.
+2. AgentConnect validates the input.
+3. AgentConnect restores the previous state of the address book.
+4. AgentConnect shows a success message confirming the undo operation.
-### Non-Functional Requirements
+ Use case ends.
+
+**Extensions**
+* 2a. No commands to undo.
+ * 2a1. AgentConnect shows an error message indicating no commands to undo.
+ * Use case ends.
+
+**Use case: Redo a Command**
+
+**MSS**
+
+1. User enters the redo command.
+2. AgentConnect validates the input.
+3. AgentConnect restores the previously undone state of the address book.
+4. AgentConnect shows a success message confirming the redo operation.
+
+ Use case ends.
+
+**Extensions**
+* 2a. No commands to redo.
+ * 2a1. AgentConnect shows an error message indicating no commands to redo.
+ * Use case ends.
+
+**Use case: Sort Clients**
+
+**MSS**
+
+1. User sort the clients by entering the sort command with a valid parameter and order.
+2. AgentConnect validates the input.
+3. AgentConnect retrieves the current client list from storage.
+4. AgentConnect sorts the clients based on the specified parameter and order.
+5. AgentConnect updates the client list in the GUI to reflect the new sorted order.
+6. AgentConnect shows a success message confirming the clients have been sorted.
+
+ Use case ends.
+
+
+**Extensions**
+
+* 2a. Sorting parameter are missing or invalid (e.g., name, insurance type, address, policy renewal date).
+ * 2a1. AgentConnect shows an error message for the invalid sorting parameter.
+ * 2a2. User corrects the sorting parameter and resubmits the command.
+ * Use case resumes from step 2.
+
+* 2b. Sorting order are missing or invalid (e.g., asc, desc).
+ * 2a1. AgentConnect shows an error message for the invalid sorting order.
+ * 2a2. User corrects the sorting order and resubmits the command.
+ * Use case resumes from step 2.
+
+
+**Use case: Edit Client Details**
+
+**MSS**
+
+1. User edits some details for an existing person by entering the edit command with index of the person and new details.
+2. AgentConnect validates the input.
+3. AgentConnect update the corresponding details of the person with the new details provided.
+4. AgentConnect shows a success message confirming the details fo the person have been edited.
+
+**Extensions**
+
+* 2a. Some fields are invalid (e.g., name, phone, email).
+ * 2a1. AgentConnect shows an error message for the invalid fields.
+ * 2a2. User corrects the fields and resubmits the command.
+ * Use case resumes from step 2.
-1. Should work on any _mainstream OS_ as long as it has Java `17` or above installed.
-2. Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage.
-3. A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse.
+* 2b. Person not found (Invalid index).
+ * 2b1. AgentConnect shows a warning message indicating index is invalid.
+ * 2b2. User resubmits the command with a valid index.
+ * Use case resumes from step 2.
+
+**Use case: Categorise client by policy**
+
+**MSS**
+
+1. User requests to list clients.
+2. User selects a client to assign a policy.
+3. AgentConnect assigns the policy to the client.
+4. AgentConnect shows updated client information.
+Use case ends.
+
+**Extensions**
+
+* 2a. Client does not exist.
+ * 2a1. AgentConnect shows an error message for the invalid client.
+ * 2a2. AgentConnect prompts the user to either enter a valid client name or add the client to AgentConnect.
+ * Use case resumes from step 2.
+
+* 2b. Policy type is not valid.
+ * 2b1. AgentConnect shows an error message for the invalid policy type.
+ * 2b2. AgentConnect prompts the user to enter a valid policy type.
+ * Use case resumes from step 2.
+
+**Use case: Retrieve appointment date**
+
+**MSS**
+
+1. User requests to list clients.
+2. User requests to view a client’s appointment dates.
+3. AgentConnect retrieves and displays the requested appointment date.
+Use case ends.
+
+**Extensions**
+
+* 2a. No appointment data available.
+ * 2a1. AgentConnect shows a message indicating no appointment date available.
+ * Use case ends.
+
+* 2b. Invalid client name.
+ * 2b1. AgentConnect shows an error message for the invalid client.
+ * 2b2. AgentConnect prompts the user to either enter a valid client name or add the client to AgentConnect.
+ * Use case resumes from step 1.
+
+
+**Use case: Retrieve client's birthday**
+
+**MSS**
+
+1. User requests to list clients.
+2. User requests to view a specific client’s birthday.
+3. AgentConnect retrieves and displays the client’s birthday.
+Use case ends.
+
+**Extensions**
+
+* 2a. No birthday data available.
+ * 2a1. AgentConnect shows a message indicating no birthday date available.
+ * Use case ends.
+
+* 2b. Invalid client name.
+ * 2b1. AgentConnect shows an error message for the invalid client.
+ * 2b2. AgentConnect prompts the user to either enter a valid client name or add the client to AgentConnect.
+ * Use case resumes from step 1.
+
+**Use case: Retrieve next payment date**
+
+**MSS**
+
+1. User requests to list clients.
+2. User requests to view a client's payment date.
+3. AgentConnect retrieves and display the next payment date.
+Use case ends.
+
+**Extensions**
+
+* 2a. No payment data available.
+ * 2a1. AgentConnect shows a message indicating no payment data available.
+ * Use case ends.
+
+* 2b. Invalid client name.
+ * 2b1. AgentConnect shows an error message for the invalid client.
+ * 2b2. AgentConnect prompts the user to either enter a valid client name or add the client to AgentConnect.
+ * Use case resumes from step 1.
*{More to be added}*
+### Non-Functional Requirements
+
+1. Should be able to hold up to 1000 persons without noticeable lag for typical usage.
+2. A user with above-average typing speed for regular English text should be able to add a new contact (including insurance and appointment details) faster using commands than with the mouse.
+3. The system should provide real-time validation (e.g., when typing the phone number or email) to reduce error rates and ensure correct input formats.
+4. Novice users should be able to complete a typical workflow in under 5 minutes, without external help.
+5. The system codebase should allow for the introduction of new features with less than 10% of existing code modification.
+6. The system should validate all inputs (e.g., phone number, email, insurance details) according to predefined formats (e.g., email must follow a standard email format) to maintain data consistency and integrity.
+7. AgentConnect should detect and handle duplicate entries (based on client name + address) by prompting users to resolve conflicts before adding a new entry.
+8. If the system encounters an unexpected error, it should display a user-friendly error message without exposing technical details and allow the user to retry the action.
+9. The system should respond to common user actions (e.g., adding or deleting a person, sorting clients) within 1 second, ensuring a smooth and responsive experience.
+
### Glossary
* **Mainstream OS**: Windows, Linux, Unix, MacOS
* **Private contact detail**: A contact detail that is not meant to be shared with others
+* **Appointment**: A scheduled meeting or event between the user and a client, managed within AgentConnect, with details like date and purpose.
+* **Policy**: An insurance or financial agreement purchased by a client, which can be categorized based on its type (e.g., Life Insurance, Health Insurance, Home Insurance).
+* **Client**: A person whose details (e.g., contact information, insurance policies, appointments) are stored and managed within AgentConnect.
+* **Duplicate Entry**: When a person with identical details (e.g., same name and address) already exists in the system, the system will flag this as a potential duplicate to avoid redundancy.
+
--------------------------------------------------------------------------------------------------------------------
@@ -343,40 +568,175 @@ testers are expected to do more *exploratory* testing.
1. Initial launch
- 1. Download the jar file and copy into an empty folder
+ 1. Download the jar file and copy into an empty folder
+ 2. Open up a terminal, and run the following command: java -jar AgentConnect.jar
+ - Expected: Shows the GUI with a set of sample contacts. The window size may not be optimum.
- 1. Double-click the jar file Expected: Shows the GUI with a set of sample contacts. The window size may not be optimum.
-
-1. Saving window preferences
+2. Saving window preferences
1. Resize the window to an optimum size. Move the window to a different location. Close the window.
+ 2. Re-launch the app by double-clicking the jar file.
+ * After attempting to open the URL, the hyperlink's visited state is reset
+ * to {@code false}.
+ *
+ * @throws Exception if an error occurs while attempting to open the URL
+ */
+ @FXML
+ private void goToUrl() {
+ try {
+ URI uri = new URI(USERGUIDE_URL);
+
+ if (Desktop.isDesktopSupported() && Desktop.getDesktop().isSupported(Desktop.Action.BROWSE)) {
+ Desktop.getDesktop().browse(uri);
+ }
+ } catch (Exception e) {
+ e.printStackTrace();
+ }
+
+ // Set condition back to not visited
+ ugLink.setVisited(false);
+ }
}
diff --git a/src/main/java/seedu/address/ui/MainWindow.java b/src/main/java/seedu/address/ui/MainWindow.java
index 79e74ef37c0..e06b30e963f 100644
--- a/src/main/java/seedu/address/ui/MainWindow.java
+++ b/src/main/java/seedu/address/ui/MainWindow.java
@@ -1,14 +1,18 @@
package seedu.address.ui;
+import java.util.Optional;
import java.util.logging.Logger;
import javafx.event.ActionEvent;
import javafx.fxml.FXML;
+import javafx.scene.control.Label;
import javafx.scene.control.MenuItem;
import javafx.scene.control.TextInputControl;
+import javafx.scene.control.TextInputDialog;
import javafx.scene.input.KeyCombination;
import javafx.scene.input.KeyEvent;
import javafx.scene.layout.StackPane;
+import javafx.scene.layout.VBox;
import javafx.stage.Stage;
import seedu.address.commons.core.GuiSettings;
import seedu.address.commons.core.LogsCenter;
@@ -193,4 +197,31 @@ private CommandResult executeCommand(String commandText) throws CommandException
throw e;
}
}
+
+ /**
+ * Displays a confirmation dialog with the specified message.
+ * The dialog prompts the user to confirm an action by typing "y".
+ *
+ * @param message The message to display in the confirmation dialog.
+ * @return {@code true} if the user types "y" to confirm, {@code false} otherwise.
+ */
+ public static boolean showConfirmationDialog(String message) {
+ TextInputDialog dialog = new TextInputDialog();
+ dialog.setTitle("Confirmation");
+ dialog.setHeaderText(null);
+
+ // Create a label with wrapping for the confirmation message
+ Label contentLabel = new Label(message + "\n(\"y\" to confirm or any other key to cancel)");
+ contentLabel.setWrapText(true); // Enable text wrapping for long messages
+ contentLabel.setMaxWidth(400);
+
+ // Get the dialog's content pane and add the label above the existing input box
+ VBox content = new VBox(contentLabel, dialog.getEditor());
+ content.setSpacing(10);
+ dialog.getDialogPane().setContent(content);
+
+ // Show the dialog and capture the result
+ Optional
* - the returned {@link CommandResult} matches {@code expectedCommandResult}
diff --git a/src/test/java/seedu/address/logic/commands/DeleteCommandTest.java b/src/test/java/seedu/address/logic/commands/DeleteCommandTest.java
index b6f332eabca..20bfb00ba5a 100644
--- a/src/test/java/seedu/address/logic/commands/DeleteCommandTest.java
+++ b/src/test/java/seedu/address/logic/commands/DeleteCommandTest.java
@@ -3,118 +3,221 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.mockStatic;
import static seedu.address.logic.commands.CommandTestUtil.assertCommandFailure;
import static seedu.address.logic.commands.CommandTestUtil.assertCommandSuccess;
-import static seedu.address.logic.commands.CommandTestUtil.showPersonAtIndex;
-import static seedu.address.testutil.TypicalIndexes.INDEX_FIRST_PERSON;
-import static seedu.address.testutil.TypicalIndexes.INDEX_SECOND_PERSON;
import static seedu.address.testutil.TypicalPersons.getTypicalAddressBook;
+import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
+import org.mockito.MockedStatic;
import seedu.address.commons.core.index.Index;
import seedu.address.logic.Messages;
+import seedu.address.logic.commands.exceptions.CommandException;
import seedu.address.model.Model;
import seedu.address.model.ModelManager;
import seedu.address.model.UserPrefs;
+import seedu.address.model.person.Name;
import seedu.address.model.person.Person;
+import seedu.address.testutil.PersonBuilder;
+import seedu.address.ui.MainWindow;
-/**
- * Contains integration tests (interaction with the Model) and unit tests for
- * {@code DeleteCommand}.
- */
public class DeleteCommandTest {
private Model model = new ModelManager(getTypicalAddressBook(), new UserPrefs());
+ @BeforeEach
+ public void setUp() {
+ // No need to mock the confirmation dialog
+ }
@Test
- public void execute_validIndexUnfilteredList_success() {
- Person personToDelete = model.getFilteredPersonList().get(INDEX_FIRST_PERSON.getZeroBased());
- DeleteCommand deleteCommand = new DeleteCommand(INDEX_FIRST_PERSON);
-
- String expectedMessage = String.format(DeleteCommand.MESSAGE_DELETE_PERSON_SUCCESS,
- Messages.format(personToDelete));
-
- ModelManager expectedModel = new ModelManager(model.getAddressBook(), new UserPrefs());
- expectedModel.deletePerson(personToDelete);
-
- assertCommandSuccess(deleteCommand, model, expectedMessage, expectedModel);
+ public void execute_invalidPolicyIndex_throwsCommandException() {
+ Person person = new PersonBuilder().withName("John Doe").withPolicies("Policy 1").build();
+ model.addPerson(person);
+ Index personIndex = Index.fromOneBased(model.getFilteredPersonList().indexOf(person) + 1);
+ Index policyIndex = Index.fromOneBased(2); // Invalid policy index
+ DeleteCommand deleteCommand = new DeleteCommand(personIndex, policyIndex);
+
+ assertCommandFailure(deleteCommand, model, Messages.MESSAGE_INVALID_POLICY_DISPLAYED_INDEX);
}
@Test
- public void execute_invalidIndexUnfilteredList_throwsCommandException() {
+ public void execute_invalidIndex_throwsCommandException() {
Index outOfBoundIndex = Index.fromOneBased(model.getFilteredPersonList().size() + 1);
DeleteCommand deleteCommand = new DeleteCommand(outOfBoundIndex);
assertCommandFailure(deleteCommand, model, Messages.MESSAGE_INVALID_PERSON_DISPLAYED_INDEX);
}
+ @Test
+ public void toString_withTargetIndexOnly_returnsExpectedString() {
+ Index targetIndex = Index.fromOneBased(1);
+ DeleteCommand deleteCommand = new DeleteCommand(targetIndex);
+
+ String expected = "seedu.address.logic.commands.DeleteCommand{targetIndex=1}";
+ assertEquals(expected, deleteCommand.toString());
+ }
@Test
- public void execute_validIndexFilteredList_success() {
- showPersonAtIndex(model, INDEX_FIRST_PERSON);
+ public void toString_withTargetIndexAndPolicyIndex_returnsExpectedString() {
+ Index targetIndex = Index.fromOneBased(1);
+ Index policyIndex = Index.fromOneBased(2);
+ DeleteCommand deleteCommand = new DeleteCommand(targetIndex, policyIndex);
- Person personToDelete = model.getFilteredPersonList().get(INDEX_FIRST_PERSON.getZeroBased());
- DeleteCommand deleteCommand = new DeleteCommand(INDEX_FIRST_PERSON);
+ String expected = "seedu.address.logic.commands.DeleteCommand{targetIndex=1, policyIndex=2}";
+ assertEquals(expected, deleteCommand.toString());
+ }
+
+ @Test
+ public void toString_withTargetNameOnly_returnsExpectedString() {
+ Name targetName = new Name("Alex Yeoh");
+ DeleteCommand deleteCommand = new DeleteCommand(targetName);
+
+ String expected = "seedu.address.logic.commands.DeleteCommand{targetName=Alex Yeoh}";
+ assertEquals(expected, deleteCommand.toString());
+ }
- String expectedMessage = String.format(DeleteCommand.MESSAGE_DELETE_PERSON_SUCCESS,
- Messages.format(personToDelete));
+ @Test
+ public void execute_deletePersonByName_success() {
+ Person person = new PersonBuilder().withName("John Doe").build();
+ model.addPerson(person);
+ DeleteCommand deleteCommand = new DeleteCommand(new Name("John Doe"));
+ String expectedMessage = String.format(DeleteCommand.MESSAGE_DELETE_PERSON_SUCCESS, person);
Model expectedModel = new ModelManager(model.getAddressBook(), new UserPrefs());
- expectedModel.deletePerson(personToDelete);
- showNoPerson(expectedModel);
+ expectedModel.deletePerson(person);
- assertCommandSuccess(deleteCommand, model, expectedMessage, expectedModel);
+ try (MockedStatic