Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revocation of NutsAuthCreds is done too quickly #272

Closed
woutslakhorst opened this issue Jun 3, 2022 · 2 comments
Closed

Revocation of NutsAuthCreds is done too quickly #272

woutslakhorst opened this issue Jun 3, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@woutslakhorst
Copy link
Member

A handoff is marked as complete at the receiver. It updates the Task at the sender. The sender immediately revokes the NutsAuthCred AND sends a Task notification. The task can no longer be retrieved because of the revoked credential.

Maybe for demo purposes don't revoke any credential?
@woutslakhorst woutslakhorst added the bug Something isn't working label Jun 3, 2022
@reinkrul
Copy link
Member

reinkrul commented Oct 6, 2022 •
edited
Loading

Or revoke after an hour or so? As in, best-effort? (it might not revoke in all cases, e.g. restart, but it still shows what should be done, in code).

It would be a simple alteration (goroutine that waits for a timeout).

@reinkrul
Copy link
Member

Will be removed for v6 release, see #480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@woutslakhorst @reinkrul