Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DID url pattern does not support accented letters #39

Closed
SimonVeldhuijzen opened this issue Dec 16, 2024 · 1 comment · Fixed by #40
Closed

DID url pattern does not support accented letters #39

SimonVeldhuijzen opened this issue Dec 16, 2024 · 1 comment · Fixed by #40
Assignees

Comments

@SimonVeldhuijzen
Copy link

Issue

The DID url pattern does not support accented letters.

As an example, this did:

did:x509:0:sha512:5wgNnRqi2EB4cIg4as6OQfIw_BTy7IGyTyWbTxLyiu7ngNOVCjICCK3q_ZpakaWrNWCtAC9ZAzesmrIT51KcdA::san:otherName:2.16.528.1.1007.99.2110-1-900029306-S-90000380-00.000-11223344::subject:O:Tést%20Zorginstelling%2001::subject:L:%27S-GRAVENHAGE

does not match because of the é character.

Context

This breaks the uzi-did-x509-issuer.

Possible solution

Proposal: add support for accented letters by adjusting the [a-zA-Z0-9.\-_:] part of the regex to [a-zA-Zà-žÀ-Ž0-9.\-_:] or, if supported, [\p{L}0-9.\-_:]

@reinkrul
Copy link
Member

Moving to uzi-did-x509-issuer, since the problem lies there. The DID specification doesn't allow accented characters in the DID, so they need to be percent-encoded. There was an attempt to fix this (#34), but this only fixes it for non-letters. I'll get a PR out that adds support for accented letters as well.

@reinkrul reinkrul transferred this issue from nuts-foundation/go-did Dec 17, 2024
@reinkrul reinkrul self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants