-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscription with echo AuthError pusher:subscription_error #2622
Comments
I don't know why you did EchoBroadcaster return that result for auth request, but changing the signature to your PusherBroadcaster fixes that: I didn't write any tests or change anything else since I have no idea about your intentions of returning the result like the way you are right now. |
Conjuring @thekonz 😉 |
I made that package and the echo broadcaster, because I was using laravel-echo-server instead of pusher. This is usually either done for privacy or cost reasons. So that You can use the echo client, but connect to pusher using the echo subscription broadcaster. |
Thanks for the reply, I'm not using pusher, as a matter of fact my server is supposed to run locally without any internet, I'm using a pusher compatible server that laravel suggests:"soketi". Also laravel echo server, doesn't seem to be maintained anymore. In any case, I'd say it makes sense to support pusher as well, you might want to support both, by specifying an option and a simple if statement between my code and yours. Or maybe it is already supported I didn't understand your last sentence: |
If you are using pusher, use the pusher broadcaster, not the echo broadcaster. The echo broadcaster was there to be used with echo server. |
Makes sense, I can't test it right now but I'm sure doing what you suggested should just fix it. I thought echo was only supposed to work with echo broadcaster. |
Describe the bug
Expected behavior/Solution
Steps to reproduce
Output/Logs
Click to expand
Lighthouse Version
6.45
The text was updated successfully, but these errors were encountered: