-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter function should receive the full route object (instead of just the url) #69
Labels
Comments
ghost
added
the
cmty:feature-request
label
Jun 16, 2019
SnirShechter
pushed a commit
to SnirShechter/sitemap-module
that referenced
this issue
Jun 16, 2019
@SnirShechter, @NicoPennec |
@NicoPennec can closed? |
@ricardogobbosouza no, it's not that. |
NicoPennec
pushed a commit
that referenced
this issue
Nov 18, 2019
@SnirShechter I just cherry-picked your commit from your still remained opened PR #70 Thank you for this contribution 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this feature solve?
The filter function receives an array of routes containing URLs and sitemap options. This means that the only way to filter the route is by final URL:
filter function - received route object
The specific need rises when we are using nuxt-i18n:
localed route
If I wish to exclude these routes, I need to use one of two options:
sitemapConfig - exclude 'about'
or
filter function - exclude 'about'
What does the proposed changes look like?
The route object can actually contain more data:
filter function - possible route object
Using that data, we can easily exclude routes by name.
filter function - new form
The text was updated successfully, but these errors were encountered: