fix: use undefined rather than null for data fetching defaults
#1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wattanx
force-pushed
the
feat/default-data-and-error
branch
5 times, most recently
from
12a5811 to
4dd914a
Compare
wattanx
force-pushed
the
feat/default-data-and-error
branch
from
4dd914a to
7bae15d
Compare
wattanx
commented
Jul 12, 2024
Comment on lines
+112
to
+117
| nuxt.options.experimental = ( | ||
| await applyDefaults( | ||
| { future: NuxtConfigSchema.future, experimental: NuxtConfigSchema.experimental }, | ||
| { future: nuxt.options.future, experimental: nuxt.options.experimental } | ||
| ) | ||
| ).experimental |
There was a problem hiding this comment.
We only want to use the default values for future and experimental.
7 tasks
|
I'm reluctant to merge this as I think it adds too much complexity to maintain. Rather, when we release Nuxt v4, perhaps we can simply directly update the default to the v4 version? |
|
I agree with the approach of directly updating the default to the v4 version! After trying it myself, I also thought it would be difficult. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#1263
Fixes: #1216
❓ Type of change
📚 Description
This updates the default values of
erroranddataforuseFetch,useAsyncDataanduseErrorin as well as upstream.It is designed to be backwards compatible as well as upstream.
📝 Checklist