Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the github username is not recognized #115

Open
patrick-hofmann opened this issue Oct 30, 2024 · 6 comments
Open

Changing the github username is not recognized #115

patrick-hofmann opened this issue Oct 30, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@patrick-hofmann
Copy link

It seems that changing the github username is not reflected correctly on the nuxters page. I get my old github username returned - even in incognito browser windows, so it doesn't seem to be a caching issue.

@TheAlexLichter TheAlexLichter added the bug Something isn't working label Jan 3, 2025
@ayanoakune
Copy link

Yes, it's because Nuxt stores the contributors data - both your Github username and Github id (user id). So when you change your username, Nuxt doesn't see that change and finds you in the contributors list via Github id.

Data is available here: https://api.nuxt.com/contributors

My suggestion for fix: When user logins into nuxters.nuxt.com, send request to "https://api.github.com/user/<github_id>" and see if data matches, if not update the name. I don't know where or how the code behind it all works, but something like that maybe could work.

Thinking a little more - Nuxt API and Nuxters are probably two separate things, so I'm doubting that it's that easy.

Also, I had same problem - and I fixed it myself. I had made 2 comments under my old username. I deleted both of them (they were not that important/impactful). This made Nuxt API to remove me from contributors list. Then under my current name I commented/helped on new Nuxt issue and got added back as with my current username. I don't recommend this approach, only if you have 1-2 comments like I did.

@arashsheyda
Copy link
Member

yes the contributors data is stored and cached. that's the reason if you give it some time the cache would get updated (as I checked now it's updated) I don't think there's much that we can do (or needed)

@ayanoakune
Copy link

How long is it cached for? My old name was shown for several months, maybe even a year. 🤔

It would be nice if user could delete their data. This would also solve compliance with GDPR (I guess?). 😄

I also feel it's okay to not change anything at the moment. Maybe shorten cache period if it's too long (if cache was the real problem for Patrick).

@patrick-hofmann
Copy link
Author

patrick-hofmann commented Mar 22, 2025

So although https://api.nuxt.com/contributors shows the new GitHub name, the page https://nuxters.nuxt.com still shows the old user name after login

@atinux
Copy link
Member

atinux commented Mar 24, 2025

I need to update manually to specify the rename. Could you please provide me:

  • old github username -> new github username

@patrick-hofmann
Copy link
Author

delta-mind-phofmann -> patrick-hofmann

Thx @atinux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants