Skip to content

Commit d8500a7

Browse files
authored
fix: type issues (#33)
1 parent 8df6b2f commit d8500a7

File tree

5 files changed

+5
-6
lines changed

5 files changed

+5
-6
lines changed

src/runtime/composables/createScriptConsentTrigger.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export function createScriptConsentTrigger(options?: ConsentPromiseOptions): Cre
3737
}, { immediate: true })
3838
}
3939
}
40-
})
40+
}) as CreateScriptConsentTriggerApi
4141
// we augment the promise with a consent API
4242
promise.accept = () => {
4343
consented.value = true

src/runtime/composables/useAnalyticsPageEvent.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export function useAnalyticsPageEvent(onChange?: (payload: TrackedPage) => void)
2020
Promise.race([
2121
// possibly no head update is needed
2222
new Promise(resolve => setTimeout(resolve, 100)),
23-
new Promise((resolve) => {
23+
new Promise<void>((resolve) => {
2424
stopDomWatcher = head.hooks.hook('dom:rendered', () => resolve())
2525
}),
2626
]).finally(() => {

src/runtime/composables/useElementScriptTrigger.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ export function useElementScriptTrigger(trigger: ElementScriptTrigger | undefine
99
return new Promise<void>(() => {})
1010

1111
const activeRef = trigger ? (trigger === 'mouseover' ? useElementHover(el) : useElementVisibility(el)) : ref(false)
12-
return trigger ? new Promise<void>(resolve => watchOnce(activeRef, resolve)) : Promise.resolve()
12+
return trigger ? new Promise<void>(resolve => watchOnce([activeRef], () => resolve())) : Promise.resolve()
1313
}

src/runtime/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import type { GoogleMapsInput } from '~/src/runtime/registry/google-maps'
1515
import type { GoogleTagManagerInput } from '~/src/runtime/registry/google-tag-manager'
1616
import type { MatomoAnalyticsInput } from '~/src/runtime/registry/matomo-analytics'
1717
import type { StripeInput } from '~/src/runtime/registry/stripe'
18-
import type { VimeoInput } from '~/src/runtime/registry/vimeo'
18+
import type { VimeoPlayerInput } from '~/src/runtime/registry/vimeo-player'
1919
import type { XPixelInput } from '~/src/runtime/registry/x-pixel'
2020

2121
export type NuxtUseScriptOptions<T = any> = Omit<UseScriptOptions<T>, 'trigger'> & {
@@ -87,7 +87,7 @@ export interface ScriptRegistry {
8787
matomoAnalytics?: ScriptRegistryEntry<MatomoAnalyticsInput>
8888
segment?: ScriptRegistryEntry<SegmentInput>
8989
stripe?: ScriptRegistryEntry<StripeInput>
90-
vimeo?: ScriptRegistryEntry<VimeoInput>
90+
vimeo?: ScriptRegistryEntry<VimeoPlayerInput>
9191
xPixel?: ScriptRegistryEntry<XPixelInput>
9292
}
9393

src/runtime/utils.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ type OptionsFn<O extends ObjectSchema<any>> = (options: Input<O>) => ({
3535

3636
export function registryScript<T extends Record<string | symbol, any>, O extends ObjectSchema<any>>(key: string, optionsFn: OptionsFn<O>, _userOptions?: RegistryScriptInput<O>) {
3737
const runtimeConfig = useRuntimeConfig().public.scripts || {}
38-
// @ts-expect-error untyped
3938
const runtimeOptions = runtimeConfig[key]
4039
const userOptions = Object.assign(_userOptions || {}, runtimeOptions || {})
4140
const options = optionsFn(userOptions)

0 commit comments

Comments
 (0)