Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select-menu): options allow value null #3327

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from

Conversation

zzxming
Copy link

@zzxming zzxming commented Feb 15, 2025

πŸ”— Linked issue

Resolves #3316

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Feb 15, 2025

npm i https://pkg.pr.new/@nuxt/ui@3327

commit: 4bf1b1a

@benjamincanac
Copy link
Member

I'm a bit confused, you made a PR for v3 to resolve an issue regarding v2 πŸ€” Also I don't see a reason to have a null item, just filter them if you need to.

@zzxming
Copy link
Author

zzxming commented Feb 15, 2025

I don't see a reason to have a null item, just filter them if you need to.

because I want keep the value null. I'm build a toolbar for rich text. I want the format value of the current selection to be consistent with the value of the select component. but if there is no such format in the current selection, null will be returned by default. so, if USelectMenu allow the value null, I don't need to make additional judgment to convert to other values when getting the current format value

you made a PR for v3 to resolve an issue regarding v2

looks like I'm push the wrong branch. which branch is v2? but when I test in local playground. it also have this issue.

@benjamincanac benjamincanac added the v3 #1289 label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USelectMenu: can not open drop select when options have value null
2 participants