Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Fix rxcpp CMake install path #301

Open
2 tasks done
mdemoret-nv opened this issue Mar 22, 2023 · 2 comments
Open
2 tasks done

[BUG]: Fix rxcpp CMake install path #301

mdemoret-nv opened this issue Mar 22, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@mdemoret-nv
Copy link
Contributor

Version

23.01

Which installation method(s) does this occur on?

Conda

Describe the bug.

When using MRC from the conda package, the install path of rxcpp is $<INSTALL_INTERFACE:include/rxcpp> when it needs to be $<INSTALL_INTERFACE:include>. Without this fix, IWYU recommends the wrong paths. For example, it recommends #include <operators/rx-map.hpp> instead of #include <rxcpp/operators/rx-map.hpp>.

Minimum reproducible example

No response

Relevant log output

No response

Full env printout

No response

Other/Misc.

No response

Code of Conduct

  • I agree to follow MRC's Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@mdemoret-nv mdemoret-nv added the bug Something isn't working label Mar 22, 2023
@cwharris
Copy link
Contributor

cwharris commented Apr 9, 2023

I don't see that we install rxcpp via conda anywhere in MRC or Morpheus. Is this for a different use case?

@mdemoret-nv
Copy link
Contributor Author

We build it from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cwharris @mdemoret-nv