Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[All] AttachOrReplaceChild throws InvalidCastException when two disposables got the same name #35

Open
vincentcastagna opened this issue Nov 17, 2021 · 0 comments
Open

[All] AttachOrReplaceChild throws InvalidCastException when two disposables got the same name #35

vincentcastagna opened this issue Nov 17, 2021 · 0 comments

Comments

@vincentcastagna
Copy link
Contributor

vincentcastagna commented Nov 17, 2021 •
edited
Loading

Expected Behavior

  • Error is not clear. AttachOrReplaceChild should take that in consideration and throw/warn that name is already registered instead

Actual Behavior

  • Throws InvalidCastException

Steps to Reproduce the Problem

  1. Add a DataLoader with a given name to a VM
  2. Use AttachOrReplaceChild and give the same name to the disposable - i.e vm being attached/replace
  3. Notice that it throws with a InvalidCastException

Specifications

  • Version: Latest
  • Platform: All
  • Subsystem:
@vincentcastagna vincentcastagna changed the title [All] AttachOrReplaceChild throws invalid cast exception when two disposables got the same name [All] AttachOrReplaceChild throws InvalidCastException when two disposables got the same name Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vincentcastagna