-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eslint for development #103
Comments
@nvh95 Have you considered any eslint configs you would like to extend? |
@Rohitbels Thanks for your support. Anything not conflict with prettier is fine. I am looking forward to see your PR 🤩 |
Okay. We can have eslintrc file for top level that will govern all top level directories not having their own package.json like src, demo, cli, and others. Every other sub directory having a package.json needs to have its own eslintrc file. PS: I would like to add going forward this project will need use workspace to improving the maintenance process. |
Thank you @Rohitbels. I am converting this project into pnpm workspace, the progress is tracked in #255 I am not available to finish it yet. But aiming for the next few weeks. For the current folder which have its own I think you can try to just add Again, thanks for your interested in helping us improve the DX of |
Is your feature request related to a problem? Please describe.
This comment https://github.com/nvh95/jest-preview/pull/79/files#r865053054 can be avoided by having
eslint
installed.Describe the solution you'd like
Integrate eslint for development env
Describe how should jest-preview implements this feature
Install eslint and related plugins (prettier, node, typescript...)
The text was updated successfully, but these errors were encountered: