Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint for development #103

Open
nvh95 opened this issue May 4, 2022 · 4 comments
Open

Add eslint for development #103

nvh95 opened this issue May 4, 2022 · 4 comments
Labels
enhancement Enhancement to current features/ behaviors

Comments

@nvh95
Copy link
Owner

nvh95 commented May 4, 2022

Is your feature request related to a problem? Please describe.
This comment https://github.com/nvh95/jest-preview/pull/79/files#r865053054 can be avoided by having eslint installed.

Describe the solution you'd like
Integrate eslint for development env

Describe how should jest-preview implements this feature
Install eslint and related plugins (prettier, node, typescript...)

@nvh95 nvh95 added the enhancement Enhancement to current features/ behaviors label May 4, 2022
@Rohitbels
Copy link
Contributor

@nvh95 Have you considered any eslint configs you would like to extend?
I can do this.

@nvh95
Copy link
Owner Author

nvh95 commented Sep 21, 2022

@Rohitbels Thanks for your support. Anything not conflict with prettier is fine. I am looking forward to see your PR 🤩

@Rohitbels
Copy link
Contributor

Rohitbels commented Sep 21, 2022

Okay.
So @nvh95
I see we have multiple subdirectories website, examples etc having their own package.json.

We can have eslintrc file for top level that will govern all top level directories not having their own package.json like src, demo, cli, and others.

Every other sub directory having a package.json needs to have its own eslintrc file.

PS: I would like to add going forward this project will need use workspace to improving the maintenance process.

@nvh95
Copy link
Owner Author

nvh95 commented Sep 21, 2022

Thank you @Rohitbels. I am converting this project into pnpm workspace, the progress is tracked in #255

I am not available to finish it yet. But aiming for the next few weeks.

For the current folder which have its own package.json. We might not need eslint for them (?). Since it's kind of "external" ones. For example, websites has nothing to do with jest-preview.

I think you can try to just add eslint for current state of the project, or you can wait a little bit longer after #255 get merged, then add eslint. It's up to you.

Again, thanks for your interested in helping us improve the DX of jest-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to current features/ behaviors
Projects
None yet
Development

No branches or pull requests

2 participants