Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set highlight groups when they are already set #42

Closed
ficcdaf opened this issue Jan 21, 2025 · 3 comments
Closed

Do not set highlight groups when they are already set #42

ficcdaf opened this issue Jan 21, 2025 · 3 comments

Comments

@ficcdaf
Copy link

ficcdaf commented Jan 21, 2025

I'm trying to set the bullets highlights to certain colors. It's frustrating that this plugin seems to always set them, even they are already set elsewhere in the configuration. I don't think the plugin should overwrite the highlights if the user has already set them.

@kristijanhusak
Copy link
Member

Can you post the code how you set them? It should not behave like that.

@ficcdaf
Copy link
Author

ficcdaf commented Jan 22, 2025

I've deleted the code, but I was trying to integrate support for this into my color scheme plugin. So, I was using the Neovim API for highlight groups to set these highlight groups:

Image

When setting the highlights inside this plugin's setup function it works as intended. But what I mean is that, if the highlight group already exists when the plugin loads (for example, it was set by a color scheme) then this plugin shouldn't overwrite the highlight.

@ficcdaf
Copy link
Author

ficcdaf commented Jan 22, 2025

I just realize this will be simple to implement. I'll submit a PR for it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants