From b64e5474ea3a271ffd0fe79c4cd1c19150636fc2 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Wed, 1 Nov 2023 16:12:12 -0700 Subject: [PATCH] [Tests] ensure windows tests install a node that actually works - disable failing Alpine tests - disable Ubuntu-18.04 tests on node 18+ - add Ubuntu-20.04 tests --- .github/workflows/windows-npm.yml | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/.github/workflows/windows-npm.yml b/.github/workflows/windows-npm.yml index e2652bb127..4ab3d58d5b 100644 --- a/.github/workflows/windows-npm.yml +++ b/.github/workflows/windows-npm.yml @@ -99,23 +99,36 @@ jobs: matrix: wsl-distrib: - Debian - - Alpine + # - Alpine # fails + - Ubuntu-20.04 - Ubuntu-18.04 npm-node-version: - '--lts' + - '21' + - '18' + - '16' - '14' - '12' - - '11' - '10' + exclude: + - wsl-distrib: Ubuntu-18.04 + npm-node-version: '--lts' + - wsl-distrib: Ubuntu-18.04 + npm-node-version: '21' + - wsl-distrib: Ubuntu-18.04 + npm-node-version: '18' method: - '' - 'script' steps: - - uses: Vampire/setup-wsl@v1 + - uses: Vampire/setup-wsl@v2 with: distribution: ${{ matrix.wsl-distrib }} additional-packages: bash git curl ca-certificates wget - name: Retrieve nvm on WSL + env: + C: /usr/bin/gcc-8 + CXX: /usr/bin/g++-8 run: | if [ -z "${{ matrix.method }}" ]; then curl -fsSLo- "https://raw.githubusercontent.com/${NVM_INSTALL_GITHUB_REPO}/${NVM_INSTALL_VERSION}/install.sh" | bash @@ -124,6 +137,7 @@ jobs: fi . "$HOME/.nvm/nvm.sh" nvm install ${{ matrix.npm-node-version }} + node -v nvm_windows: name: 'tests, on windows'