From 7169520f1607314086656d054a0ad4d9645a5720 Mon Sep 17 00:00:00 2001
From: Jhett Black <10942655+jhett12321@users.noreply.github.com>
Date: Sun, 19 Jan 2025 22:31:17 +0100
Subject: [PATCH] Fix code analysis warnings.
---
NWN.Anvil/src/main/API/Color.cs | 1 -
NWN.Anvil/src/main/API/EngineStructures/EngineStructure.cs | 1 -
NWN.Anvil/src/main/API/Extensions/IntegerExtensions.cs | 1 -
NWN.Anvil/src/main/API/Objects/NwModule.cs | 3 +--
NWN.Anvil/src/main/API/Ruleset/NwBaseItem.cs | 2 +-
NWN.Anvil/src/main/Services/Core/EncodingService.cs | 1 -
6 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/NWN.Anvil/src/main/API/Color.cs b/NWN.Anvil/src/main/API/Color.cs
index 477232c19..dd482041c 100644
--- a/NWN.Anvil/src/main/API/Color.cs
+++ b/NWN.Anvil/src/main/API/Color.cs
@@ -1,6 +1,5 @@
using System;
using Newtonsoft.Json;
-using NWN.Native.API;
using NWNX.NET.Native;
namespace Anvil.API
diff --git a/NWN.Anvil/src/main/API/EngineStructures/EngineStructure.cs b/NWN.Anvil/src/main/API/EngineStructures/EngineStructure.cs
index 05e0df7fe..b5e40b65b 100644
--- a/NWN.Anvil/src/main/API/EngineStructures/EngineStructure.cs
+++ b/NWN.Anvil/src/main/API/EngineStructures/EngineStructure.cs
@@ -1,5 +1,4 @@
using System;
-using NWN.Core;
using NWNX.NET;
namespace Anvil.API
diff --git a/NWN.Anvil/src/main/API/Extensions/IntegerExtensions.cs b/NWN.Anvil/src/main/API/Extensions/IntegerExtensions.cs
index 8e95c19ab..03fe3d152 100644
--- a/NWN.Anvil/src/main/API/Extensions/IntegerExtensions.cs
+++ b/NWN.Anvil/src/main/API/Extensions/IntegerExtensions.cs
@@ -1,6 +1,5 @@
using System;
using Anvil.Internal;
-using Anvil.Native;
using NWN.Core;
using NWN.Native.API;
diff --git a/NWN.Anvil/src/main/API/Objects/NwModule.cs b/NWN.Anvil/src/main/API/Objects/NwModule.cs
index 6ffb1fed3..1cdae03a4 100644
--- a/NWN.Anvil/src/main/API/Objects/NwModule.cs
+++ b/NWN.Anvil/src/main/API/Objects/NwModule.cs
@@ -3,7 +3,6 @@
using System.Diagnostics.CodeAnalysis;
using System.Linq;
using Anvil.Internal;
-using Anvil.Native;
using NWN.Core;
using NWN.Native.API;
@@ -131,7 +130,7 @@ public int MaxHenchmen
/// <summary>
/// Gets the current player count.
/// </summary>
- public int PlayerCount => LowLevel.ServerExoApp.m_pcExoAppInternal.m_lstPlayerList.Count();
+ public int PlayerCount => LowLevel.ServerExoApp.m_pcExoAppInternal.m_lstPlayerList.Count;
/// <summary>
/// Gets all current online players.
diff --git a/NWN.Anvil/src/main/API/Ruleset/NwBaseItem.cs b/NWN.Anvil/src/main/API/Ruleset/NwBaseItem.cs
index efcf4ceda..324f5c26c 100644
--- a/NWN.Anvil/src/main/API/Ruleset/NwBaseItem.cs
+++ b/NWN.Anvil/src/main/API/Ruleset/NwBaseItem.cs
@@ -190,7 +190,7 @@ internal NwBaseItem(uint baseItemId, CNWBaseItem baseItemInfo)
/// Gets the ResRef of the item's model, or the base part of the resref.<br/>
/// This property is dependent on <see cref="ModelType"/>. See https://nwn.wiki/display/NWN1/baseitems.2da for more info.
/// </summary>
- public unsafe string? ItemClass
+ public string ItemClass
{
get
{
diff --git a/NWN.Anvil/src/main/Services/Core/EncodingService.cs b/NWN.Anvil/src/main/Services/Core/EncodingService.cs
index 29ea545dd..3794e9083 100644
--- a/NWN.Anvil/src/main/Services/Core/EncodingService.cs
+++ b/NWN.Anvil/src/main/Services/Core/EncodingService.cs
@@ -1,7 +1,6 @@
using System;
using System.Text;
using Anvil.Internal;
-using NWN.Core;
using NWNX.NET.Native;
namespace Anvil.Services