-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOM node attribute changes not caught by handler #19
Comments
Hi! I will answer the PS and check the issue only later if that works for you 🙂 Yes, I promised a lot and failed to deliver recently, but I do not want to ditch the project. This was my 'learning framework' and I think it can be really felt in the way I handled things here. Currently I am making a stack for React (Easy State and Easy Params are ready so far if you are interested). After I am done with that - which should be in a month (this time really 🙂 ) - I want to turn back to NX with a lot of new experiences. I think these are the most urgent issues:
After these we could start adding new features 🙂 In the next month I can't promise to put much work into this, but after that I can join. Would you like to get started with these, what are your opinion about them? I will try to clean up my unpushed code and put it on a branch - after the mono-repo is done - for review. I would be really grateful for a buddy on this project 🙂 Issue checking is coming in the next comment. |
It seems to be a lot of separate issues to me.
I hope these helped, thanks for the issue! |
Hi, thx for the timely reply, I'll put the P.S. part first as it's more relevant:
now about the issue part, long story short, I made a mistake... the other parts of the problem is caused by me: I'm refactoring the code, and moved the reaction function to a callback by mistake, so it stopped working. the object got from a Proxy inside a synchronous reaction function call is Proxy, which is exactly what I expected. sorry for the false alarm. |
using nx beta 2.0.0 downloaded from https://nx-framework.com/install,
running on Mac OSX 10.10.5, Chrome 60.0.3112.113 (Official Build) (64-bit).
both of these are the newest versions as of writing this.
minimal code to illustrate the problem:
console output when running the above example was:
address changed to old
and nothing more.why changes made to the attribute is not caught, am I missing something here?
P.S.: nx is the best framework I've found so far, Vue has too many "edge cases". but development is too slow for this project, a lot of promised changes seems missing, so I'd like to work on this project to speed things up. what I'd like to do first is to restructure the project as it seems to scattered to me:
I'd like to make a new branch to nx-js/framework, and make every middleware
(which are in their individual repos, most of them can be made into in a single file)
a separate file inside nx-js/framework/middlewares, and move in other dependencies too.
I think by doing this, it allows easier collaborations and will speed up development, in the same time not sacrificing modularity too much. is this ok to you?
The text was updated successfully, but these errors were encountered: