Cleanup some handler code #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Oct 3, 2023
| if err != nil { | ||
| return status, err | ||
| } | ||
| jsonBody := jsonx.MustMarshal(payload) |
There was a problem hiding this comment.
these are structs we control... and we know they can't fail marshaling
rowanseymour
commented
Oct 3, 2023
| @@ -719,16 +720,13 @@ func (h *handler) sendFacebookInstagramMsg(ctx context.Context, msg courier.MsgO | |||
| // include any quick replies on the last piece we send | |||
| if part.IsLast { | |||
| for _, qr := range msg.QuickReplies() { | |||
| payload.Message.QuickReplies = append(payload.Message.QuickReplies, messenger.QuickReply{qr, qr, "text"}) | |||
| payload.Message.QuickReplies = append(payload.Message.QuickReplies, messenger.QuickReply{Title: qr, Payload: qr, ContentType: "text"}) | |||
rowanseymour
commented
Oct 3, 2023
| @@ -1094,15 +1092,12 @@ func (h *handler) sendWhatsAppMsg(ctx context.Context, msg courier.MsgOut, clog | |||
| return status, nil | |||
| } | |||
|
|
|||
| func requestWAC(payload whatsapp.SendRequest, accessToken string, status courier.StatusUpdate, wacPhoneURL *url.URL, zeroIndex bool, clog *courier.ChannelLog) (courier.StatusUpdate, error) { | |||
There was a problem hiding this comment.
redundant passing in status and returning it
Codecov Report
@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 73.95% 74.24% +0.29%
==========================================
Files 99 99
Lines 13184 13147 -37
==========================================
+ Hits 9750 9761 +11
+ Misses 2729 2697 -32
+ Partials 705 689 -16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.