Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow JSON becoming invalid by following the mentioned steps #1205

Closed
mdshamoon opened this issue Nov 15, 2023 · 6 comments
Closed

Flow JSON becoming invalid by following the mentioned steps #1205

mdshamoon opened this issue Nov 15, 2023 · 6 comments
Labels

Comments

@mdshamoon
Copy link
Contributor

Describe the bug
The flow JSON becomes invalid when following the below mentioned steps. Might be an edge condition but we are seeing this once in every two months by one of our users.

To Reproduce
https://github.com/nyaruka/rapidpro/assets/32592458/07069d7c-4d77-4a3b-bd7f-a18e2f5588da

Expected behavior
There should be no errors

@mdshamoon mdshamoon added the bug label Nov 15, 2023
@ericnewcomer ericnewcomer transferred this issue from nyaruka/rapidpro Nov 15, 2023
@ericnewcomer
Copy link
Member

Just some notes here:

  • Was able to reproduce following the precise steps
  • The flow definition is not saved since it fails validation
  • Refreshing and removing the same node succeeds, so it has something to do with active state during creation using these steps

Copy link

Without activity, this issue will be closed in 14 days.

@mdshamoon
Copy link
Contributor Author

mdshamoon commented Dec 23, 2023

@ericnewcomer are you checking this. This seems to happen more frequently now for our users.
Let me know if I can raise a PR for the fix.

@ericnewcomer
Copy link
Member

Thanks, I'm on holiday until January 2nd, but will have a look when I'm back!

@mdshamoon
Copy link
Contributor Author

Sure thanks. Happy holidays and a great new year.

@ericnewcomer
Copy link
Member

This has been merged and released as of v1.26.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants