From 29750e458771bd231cb463c3f3ae6164c60a41e2 Mon Sep 17 00:00:00 2001 From: Rowan Seymour Date: Fri, 16 Mar 2018 15:01:34 -0500 Subject: [PATCH] Expression error shouldn't prevent add urn action (e.g. email that looks like expression) --- flows/actions/add_contact_urn.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/flows/actions/add_contact_urn.go b/flows/actions/add_contact_urn.go index e33128a0d..0a05fd084 100644 --- a/flows/actions/add_contact_urn.go +++ b/flows/actions/add_contact_urn.go @@ -51,10 +51,9 @@ func (a *AddContactURNAction) Execute(run flows.FlowRun, step flows.Step, log fl evaluatedPath, err := excellent.EvaluateTemplateAsString(run.Environment(), run.Context(), a.Path, false) - // if we received an error, log it + // if we received an error, log it although it might just be a non-expression like foo@bar.com if err != nil { log.Add(events.NewErrorEvent(err)) - return nil } // if we don't have a valid URN, log error