Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for contact-less sessions #1192

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

rowanseymour
Copy link
Member

Not convinced it ever worked and we have no plans to ever utilize this functionality

Also drops long deprecated connection field on IVR triggers which was replaced by call

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #1192 (c35e2a2) into main (e3856f2) will decrease coverage by 0.05%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             main    #1192      +/-   ##
==========================================
- Coverage   87.71%   87.66%   -0.05%     
==========================================
  Files         262      262              
  Lines       11002    10961      -41     
==========================================
- Hits         9650     9609      -41     
  Misses        929      929              
  Partials      423      423              
Files Coverage Δ
flows/actions/add_contact_groups.go 100.00% <ø> (ø)
flows/actions/add_contact_urn.go 100.00% <ø> (ø)
flows/actions/remove_contact_groups.go 100.00% <ø> (ø)
flows/actions/send_msg.go 90.00% <ø> (-0.70%) ⬇️
flows/actions/set_contact_channel.go 100.00% <ø> (ø)
flows/actions/set_contact_field.go 100.00% <ø> (ø)
flows/actions/set_contact_language.go 100.00% <ø> (ø)
flows/actions/set_contact_name.go 100.00% <ø> (ø)
flows/actions/set_contact_status.go 100.00% <ø> (ø)
flows/actions/set_contact_timezone.go 100.00% <ø> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rowanseymour rowanseymour merged commit fbb853d into main Oct 6, 2023
5 of 7 checks passed
@rowanseymour rowanseymour deleted the contact_required branch October 6, 2023 21:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant