Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework results so they're keyed by name rather than snakified name #1295

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

rowanseymour
Copy link
Member

@rowanseymour rowanseymour commented Dec 5, 2024

Snakified name is really just for expressions. To maintain the existing storage format on runs, mailroom can snakify the names.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (8a46e3a) to head (cf32f41).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1295   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files         276      276           
  Lines       21349    21349           
=======================================
  Hits        17457    17457           
  Misses       3318     3318           
  Partials      574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit e80c8e0 into main Dec 10, 2024
7 checks passed
@rowanseymour rowanseymour deleted the results_by_name branch December 10, 2024 16:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant