Restrict search by location to visible bounds

[lklepner]

Searching for maps by location returns results which are not visible in the current location. It would be more accurate/useful if the results only contained maps which have visible content with the search bounds.

[mgiraldo]

search by location (i think) returns maps whose bounds intersect with the current map interface rectangle. is this not the case? one change could be to show maps whose bounds are contained by the interface. that would reduce the amount of results significantly, though.

[lklepner]

It seems the search by location is returning maps which don't have visible map (cropped image) within the search bounds. Some of the results are matching on the overscan or color guide, not the cropped area of the map.

If you search maps by location using the zip 10522 (Dobbs Ferry) you'll find the map below in the results (and and a number of other maps which don't actually cover Dobbs) which I've been guessing is a result of using the raw bound of the rectified image, not the bound of the cropped area.
http://maps.nypl.org/warper/maps/26772

[lklepner]

I suspect the search results are inaccurate since the clipmap_bounds is being saved incorrectly - #45

[mgiraldo]

yeah. @bertspaan is working on tools that surface problematic maps (no/wrong crop, no bbox, etc). i just started working on saving the map rectify and resampling modes.

[lklepner]

awesome. i'll keep focusing on UI refinements.