Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide Message fields #8

Open
nikhan opened this issue Jul 28, 2014 · 1 comment
Open

hide Message fields #8

nikhan opened this issue Jul 28, 2014 · 1 comment

Comments

@nikhan
Copy link
Contributor

nikhan commented Jul 28, 2014

There are several fields in the Message type that are used by Colony internals, that if modified by a user, could create mayhem.

For instance, if a service could receive messages and change MessageID, Time, ContentType, Topic, etc, and "respond" and who knows where the message would go or what it would do. IMO, any field expressing state within Colony should be hidden or have some kind of getter.

@mikedewar
Copy link
Collaborator

I think getters is a good idea.
On Jul 28, 2014 5:40 PM, "nik hanselmann" [email protected] wrote:

There are several fields in the Message type that are internally used by
Colony internals, that if modified by a user, could create mayhem.

For instance, if a service could receive messages and change MessageID,
Time, ContentType, Topic, etc, and "respond" and who knows where the
message would go or what it would do. IMO, any field expressing state
within Colony should be hidden or have some kind of getter.


Reply to this email directly or view it on GitHub
#8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants