Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SANITIZER and STARVED exec result codes #13

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Conversation

acidghost
Copy link
Contributor

Fixes #12.

Not sure if the associations with NyxReturnValue are fine or more variants of it should be added for the new result codes.

@acidghost acidghost changed the title WIP: add SANITIZER and STARVED exec result codes add SANITIZER and STARVED exec result codes Apr 16, 2022
@schumilo schumilo changed the base branch from main to dev April 18, 2022 20:51
@schumilo schumilo merged commit 3a6a473 into nyx-fuzz:dev Apr 18, 2022
@schumilo
Copy link
Member

I think it’s fine for now. AFAIK both result codes are only used by Intel's kAFL fork (though the fork doesn't use libnyx yet). But yeah...we should definitely extend NxyReturnValue in the future.
Anyway, thanks again for your PR :)

@acidghost
Copy link
Contributor Author

@schumilo actually I got the "starved" result code from QEMU-Nyx, which crashed the fuzzer 😅 . It was recently merged into the main branch from qemu-nyx-4.2.0-dev-intel (nyx-fuzz/QEMU-Nyx#10).

@il-steffen
Copy link

@acidghost the starved result code should only trigger if you provide non-zero argument in the RELEASE hypercall. Did you observe something different?

nyx-fuzz/QEMU-Nyx@c12c6bd#diff-1872baa30d6294198890713430742623fe37ffe1912e9df79c9b76a9746eb1d6

@il-steffen
Copy link

@schumilo I guess this bit is another candidate for the generic ijon/aux return info buffer

@acidghost
Copy link
Contributor Author

@il-steffen I'm aware of that, but I can trigger the crash reliably on LightFTP (see nyx-fuzz/packer#10) 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Needs to be updated to support latest QEMU return values
3 participants