Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have basic auth url encode "at" symbol etc. in password. #902

Open
OkkeKlein opened this issue Dec 1, 2023 · 5 comments
Open

Can we have basic auth url encode "at" symbol etc. in password. #902

OkkeKlein opened this issue Dec 1, 2023 · 5 comments

Comments

@OkkeKlein
Copy link
Contributor

And maybe in user value also if it makes sense.

@epugh
Copy link
Member

epugh commented Dec 1, 2023

Can you hook me up with an example? Like, are you thinking that instead of reader:password you want to support re@der:p@assword and have that work?

@OkkeKlein
Copy link
Contributor Author

Using your example this would become re%40der:p%40assword

@epugh
Copy link
Member

epugh commented Dec 5, 2023

So, I think that with the release of 7.12.3 and the fixes for Solr and basic auth, that you don't need this because instead of the basic auth in the url, it's a properly encoded header....

@epugh
Copy link
Member

epugh commented Dec 5, 2023

I've now pushed the changes to app.quepid.com as well...

@OkkeKlein
Copy link
Contributor Author

I have tested with version 7.17.1 Both the urlencoded and unencoded password containing hash and ampersand failed to connect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants