Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect behavior of finding all joints in JointPositionEditorComponent #812

Open
adamdbrw opened this issue Dec 30, 2024 · 0 comments · May be fixed by #814
Open

Incorrect behavior of finding all joints in JointPositionEditorComponent #812

adamdbrw opened this issue Dec 30, 2024 · 0 comments · May be fixed by #814
Labels
feature/robotics This item is related to robotics. kind/bug Categorizes issue or PR as related to a bug. priority/major Major priority. Work that should be handled after all blocking and critical work is done. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation

Comments

@adamdbrw
Copy link
Contributor

Describe the bug
New joints are appended to the list, instead of replacing them.
Also, fixed joints are included in the list, but should not be included.

Assets required
ROS 2 Gem

Steps to reproduce

  • Create an entity tree.
  • Add a JointsPositionEditorComponent to the top entity.
  • Have any number of joints in the entity tree below.
  • Click "Find all joints" several times

Expected behavior
The list stays the same with each finding.

Actual behavior
The list grows, appending joints.

Screenshots/Video
Screencast from 12-30-2024 04:14:21 PM.webm

Found in Branch
main (O3DE / o3de-extras)
Also confirmed in development

Commit ID from o3de/o3de
c602b493dbb91b246f479cb4fc35bbbcf3f55228

Commit ID for o3de/o3de-extras
7801ad7

Desktop/Device (please complete the following information):

  • Device: PC
  • OS: Linux Ubuntu 22.04

(device is believed to be irrelevant as this is most likely logic error)

Additional context
Similar "Reload" feature does not append in JointMainpulationEditorComponent (good), but includes fixed joints as well (bad).
@adamdbrw adamdbrw added kind/bug Categorizes issue or PR as related to a bug. priority/major Major priority. Work that should be handled after all blocking and critical work is done. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation feature/robotics This item is related to robotics. labels Dec 30, 2024
@arturkamieniecki arturkamieniecki linked a pull request Dec 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/robotics This item is related to robotics. kind/bug Categorizes issue or PR as related to a bug. priority/major Major priority. Work that should be handled after all blocking and critical work is done. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug where joints werent clearing in JointPositionEditorComponent RobotecAI/o3de-extras
1 participant
@adamdbrw