Upload file garbage cans are misaligned

[mrvisser]

Chrome 45, Mac OSX.

Ideally we could find a way to vertically align these items without relying on one-off margin offsets, as these vertical alignment issues seem to happen frequently.

If we can drop IE9 support, more options such as flexbox come available.

[nicolaasmatthijs]

A line height that is equal to the height of the row it's in ?

[mrvisser]

That's one way to vertically centre, but I think the height of the row always changes, because it's driven by the size of the contents inside it, and paddings always seem to need tweaking. That's where trying to match up line-height of element X with new row height of element Y seems to be brittle because they can easily get out of sync.

[noncototient]

Could you please provide a dev login to the area where this upload field is and provide a link where to login?

[sallakarppinen]

Hello @noncototient, you can create an account for yourself here, and once you've logged in, you will be able to see the 'Upload' clip in the top right corner of the screen. This bug becomes apparent when more than one file is added via the 'Browse' -dialog - you won't need to actually upload any files if you don't want to. Does that help you get started?

[noncototient]

Hey @sallakarppinen, yeah just created an account and logged in. Will try to fix this tonight

[sallakarppinen]

Thanks a lot @noncototient, if you have any more questions please ask!

[noncototient]

Hey guys, so with quick absolute positioning I managed to center all the icons like so (just the top upload showing all icons at once to fit in one image):

I can submit a pull request in a few hours with the fixes shown in that pic, if you like what you see there.

Also:

That's one way to vertically center, but I think the height of the row always changes, because it's driven by the size of the contents inside it, and paddings always seem to need tweaking.

I haven't noticed the content being different heights, it seems like it stays the same regardless of files. Am I missing something here?

[sallakarppinen]

I haven't noticed the content being different heights, it seems like it stays the same regardless of files. Am I missing something here?

I think the different heights issue has been fixed previously so this is just the icons now... Your fix looks good, please do submit a PR for it!

[noncototient]

Sure! Will do once I manage to get your system running locally. I just made those changes on live website in chrome dev tools :D

[sallakarppinen]

Hiya @noncototient, I know it's been a while but I was wondering if you managed to make this change locally? We've recently made changes to Hilary to allow the app be run on dockers, so it should be a bit easier to get it up and running now if that was causing you problems before.

[Ashutosh0602]

If this issue is not completed then you can assign me I can fix it.