-
Notifications
You must be signed in to change notification settings - Fork 36
Nightlight depends on clojure 1.9 but doesn't. #51
Comments
Ah, good point. The real cause of this is that defexample is using clojure.spec. I believe at least two libraries that Nightlight uses depend on defexample: eval-soup and Dynadoc. I could actually fix this by using clojure-future-spec but since 1.9 is out now perhaps it's best to just require it. I'm not sure what the best thing to do is regarding the pom file. Normally people suggest always making clojure as |
For my use case, requiring Clojure 1.9 is not a problem. The library that I am editing with nightlight only requires 1.7, though. And leiningen by default seems to be conservative with Clojure versions -- if you say "1.7" this is what it uses, although it could validly choose to use 1.9 assuming some semantics to versioning. I'm a bit dubious about |
Hello, I don't have much experience with clojure. Could you provide more detailed instructions about how to fix this ? I'm already using clojure 1.9.0 |
Ok, seems that you have to require clojure 1.9.0 specifically. I was requiring an alpha. here is the head of my project.clj working (defproject hello-world "0.1.0-SNAPSHOT"
:description "FIXME: write this!"
:url "http://example.com/FIXME"
:min-lein-version "2.7.1"
:dependencies [[org.clojure/clojure "1.9.0"]
[org.clojure/clojurescript "1.9.908"]
[nightlight "RELEASE"]]
|
Just upgraded to 2.1.3 (from 1.9 something or other).
I am getting an exception (see below). It's possible to workaround by
specifically adding Clojure 1.9 as a dependency. I think the error comes
from dynadoc actually, but I can't quite see where or why nightlight depends
on it.
Anyway, practical upshot. Nightlight appears to depend on Clojure 1.9
(or spec anyway), but doesn't explicitly state so in it's pom.
Thanks for the project; great tool.
The text was updated successfully, but these errors were encountered: