Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about udevadminfo actor? #762

Open
linux-gcc opened this issue Nov 24, 2021 · 1 comment
Open

A question about udevadminfo actor? #762

linux-gcc opened this issue Nov 24, 2021 · 1 comment
Labels
deprecation Any change in the set of deprecation functionality. enhancement New feature or request question Further information is requested

Comments

@linux-gcc
Copy link

What is the purpose of designing udevadminfo actor?
It seems that no other actor currently uses the data generated by it?

@linux-gcc linux-gcc added the bug Something isn't working label Nov 24, 2021
@vinzenz vinzenz added deprecation Any change in the set of deprecation functionality. enhancement New feature or request and removed bug Something isn't working labels Nov 24, 2021
@vinzenz
Copy link
Member

vinzenz commented Nov 24, 2021

Previously the data has been used for the CheckKernelDrivers and was part of PR #172
Since then, we moved on to a different way of collecting the data needed by this actor.

As of now, we did not consider marking the data as deprecated and we do usually keep Messages around that might be used by anyone extending the upgrade process.

It's a good point, though that this model should be potentially deprecated, however it is not a bug.

Thanks for asking.

@pirat89 pirat89 added the question Further information is requested label Nov 25, 2021
MichalHe pushed a commit to MichalHe/leapp-repository that referenced this issue Jun 21, 2022
Currently we have 2 reason fields in dialogs
  - one 'generic', for the dialog itself
  - one specific just for the particular user question

The framework now prints only the first one, which in some cases
hides important text connected to the particular question. Printing
both reasons now.
MichalHe pushed a commit to MichalHe/leapp-repository that referenced this issue Jun 21, 2022
## Packaging

- Add depency on `python3` for el8+ (`python3` refers to the distribution python)
- Bump `leapp-framework` to 2.2
- Bump `leapp-framework-dependencies` to 6
- Doc: --report-schema in manpage (oamg#686)

## Framework
### Fixes

- Fix issues with initialisation of loggers (oamg#764)
- Fix TypeError during JSON serialization in dialogs on Python3 (oamg#760)
- Prevent breaking the answerfile when dialog fields contain newlines (oamg#757)
- Check answerfile upon loading (oamg#759)
- Fix the multiprocessing on Python 3.9 on Mac OS

### Enhancements

- Dialogs: print the reason field for question in the answerfile (oamg#762)
- Added possibility to specify the report format version (oamg#686)

## stdlib

### Enhancements
- Introduced `stdlib.path` library `get_common_*_path` functions for the scanning repositories, actors, etc. paths outside of the actor execution (oamg#742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Any change in the set of deprecation functionality. enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants