aggreate with varbinary type fail with

[gaoyangxiaozhu]

Bug description

When run below spark query which has aggregate based on varbianry type. The sql will fail with

Caused by: java.lang.RuntimeException: Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: Unknown input type for min aggregation VARBINARY
Retriable: False
Expression: false
Function: operator()
File: /home/gayangya/Work/Git/OSS/velox/velox/functions/prestosql/aggregates/MinMaxAggregates.cpp
Line: 516
Stack trace:

import org.apache.spark.sql.Row
import org.apache.spark.sql.types.{BinaryType, BooleanType, ByteType, DateType, Decimal, DecimalType, DoubleType, FloatType, IntegerType, LongType, ShortType, StringType, StructField, StructType, TimestampType}

import java.sql.{Date, Timestamp}

implicit class StringToDate(s: String) {
  def date: Date = Date.valueOf(s)
}

implicit class StringToTs(s: String) {
  def ts: Timestamp = Timestamp.valueOf(s)
}

val rows =
  Seq(
    Row(
      "sparkSQL",
      "Spark SQL".getBytes),
    Row(
      "parquet",
      "Parquet".getBytes),
    Row(
      "sparkML",
      "SparkML".getBytes)
  )

val schema = StructType(List(
  StructField("StringCol", StringType, true),
  StructField("BinaryCol", BinaryType, false)).toArray)

val rdd = sc.parallelize(rows)

spark.createDataFrame(rdd, schema).write.format("parquet").save("/tmp/spark1/datatest1")

spark.read.format("parquet").load("/tmp/spark1/datatest1").createOrReplaceTempView("test")
val df = sql("SELECT min(BinaryCol) FROM test")
df.collect

Expected behavior:

It run spark sql successfully.

System information

ubuntu 20.04

Relevant logs

Caused by: java.lang.RuntimeException: Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: Unknown input type for min aggregation VARBINARY
Retriable: False
Expression: false
Function: operator()
File: /home/gayangya/Work/Git/OSS/velox/velox/functions/prestosql/aggregates/MinMaxAggregates.cpp
Line: 516
Stack trace:

This is also causes glutet ut aggregate push down - different data types of GlutenParquetV2AggregatePushDownSuite fail which traced by another issue apache/incubator-gluten#2169

[gaoyangxiaozhu]

close with PR merged