Build error

[zhli1142015]

Bug description

https://github.com/oap-project/velox/blame/2024_03_18/velox/dwio/parquet/tests/reader/ParquetTableScanTest.cpp#L508C9-L510C72
__w/1/s/velox/dwio/parquet/tests/reader/ParquetTableScanTest.cpp:511:69: error: expected ')' before ';' token
511 | assertSelectWithFilter({"name"}, {}, "", "SELECT (null, 'Jones')");
| ^
| )
/__w/1/s/velox/dwio/parquet/tests/reader/ParquetTableScanTest.cpp:508:11: note: to match this '('
508 | loadData(
| ^

System information

Velox System Info v0.0.2
Commit: 73ee632
CMake Version: 3.22.1
System: Linux-5.15.146.1-microsoft-standard-WSL2
Arch: x86_64
C++ Compiler: /usr/bin/c++
C++ Compiler Version: 11.4.0
C Compiler: /usr/bin/cc
C Compiler Version: 11.4.0
CMake Prefix Path: /usr/local;/usr;/;/usr;/usr/local;/usr/X11R6;/usr/pkg;/opt

Relevant logs

No response

[zhli1142015]

cc @rui-mo and @zhouyuan , thanks

[yma11]

@zhli1142015 I met this issue. rm _build folder and build again can help. Velox has a commit which may already fix this issue.

[zhli1142015]

I thought this maybe a different issue.
error: expected ')' before ';' token

[yma11]

This is the same error I met and rebuild after deleting _build works. But I did not try with latest velox. So above error happens in latest velox?

[zhli1142015]

This is found on 3_17 branch, I think 3_18 shoud have same issue. It's reported by our build pipeline which should starts build from a clean environment.
I think makeRowVector is missed in line 508 loadData.

[yma11]

3_18 rebase has already passed Gluten CI and merged. Let me double check by a local build.

[zhli1142015]

I thought velox ut is not covered by Gluten CI.

[yma11]

I thought velox ut is not covered by Gluten CI.

Yes. We don't enable parquet by default in Velox. I can reproduce it and will do a force update on corresponding branches. Thanks for reporting this!

[yma11]

Done. Updated 2024_03_18 and update branch.

[zhli1142015]

Thanks.