Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orchestrator fails when using HTTP protocol #62

Open
mvle opened this issue Jul 6, 2022 · 2 comments
Open

Orchestrator fails when using HTTP protocol #62

mvle opened this issue Jul 6, 2022 · 2 comments

Comments

@mvle
Copy link

mvle commented Jul 6, 2022

Referring to the latest in develop https://github.com/ScreamBun/openc2-oif-orchestrator

The error is trans.path doesn't exist for HTTP. Not sure if the below is the correct fix but I put it here for your reference.

diff --git a/orchestrator/producer-core/producer_server/command/views/actions.py b/orchestrator/producer-core/producer_server/command/views/actions.py
index 04daa4a..aa1ad19 100644
--- a/orchestrator/producer-core/producer_server/command/views/actions.py
+++ b/orchestrator/producer-core/producer_server/command/views/actions.py
@@ -190,7 +190,7 @@ def get_headers(proto: Protocol, com: SentHistory, proto_acts: List[Actuator], s
                     **({'format': fmt} if fmt else {})
                 )
 
-            if trans.protocol.name.startswith('HTTP'):
+            if trans.protocol.name.startswith('HTTPS'):
                 dst.update(
                     path=trans.path
                 )
@ScreamBun
Copy link
Contributor

Yes that is one option to correct the issue.

The HTTP transport was incorporated into the HTTPS transport for development use. This instance seems to have been missed during the update of the transport.

@ScreamBun
Copy link
Contributor

We are planning to refresh this area of the app in the very near future. We will make sure to incorporate this finding in our refreshed code base. Keeping this open, until it is included in development of the refreshed code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants