Do not crash on tid == -1 in sys_thr_set_name #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuchAFuriousDeath
previously requested changes
Feb 18, 2024
mikusp
force-pushed
the
handle_negative_tid_in_thr_set_name
branch
from
7645db4
to
5d55551
Compare
SuchAFuriousDeath
approved these changes
Feb 23, 2024
VocalFan
approved these changes
Feb 23, 2024
|
Actually this is not the correct way to fix this. This is a bug in the value conversion code. |
|
I told VocalFan to merge this, because it's already done this way in sys_cpuset_getaffinity, so I assumed that it's acceptable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation thought of tid == -1 but it crashed on unwrapping the conversion to i32. This is called by system app ShellAppProxy