Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements sys_dynlib_get_info #672

Merged
merged 58 commits into from
Apr 5, 2024
Merged

Implements sys_dynlib_get_info #672

merged 58 commits into from
Apr 5, 2024

Conversation

SuchAFuriousDeath
Copy link
Contributor

No description provided.

@SuchAFuriousDeath SuchAFuriousDeath requested a review from a team February 18, 2024 19:20
@SuchAFuriousDeath SuchAFuriousDeath marked this pull request as draft February 18, 2024 19:23
@SuchAFuriousDeath SuchAFuriousDeath marked this pull request as ready for review February 21, 2024 00:33
@SuchAFuriousDeath SuchAFuriousDeath marked this pull request as draft February 21, 2024 00:33
@SuchAFuriousDeath SuchAFuriousDeath linked an issue Feb 21, 2024 that may be closed by this pull request
Implement sys_dynlib_get_info #664
Closed
@SuchAFuriousDeath SuchAFuriousDeath marked this pull request as ready for review February 21, 2024 21:02
@SuchAFuriousDeath SuchAFuriousDeath marked this pull request as draft February 21, 2024 21:03
@SuchAFuriousDeath
Copy link
Contributor Author

I think this is correct now, but we should probably wait until this syscall is reached until we merge this

@SuchAFuriousDeath
Copy link
Contributor Author

@ultimaweapon By the way, shouldn't relro and relro_size be stored inside a module too?

@ultimaweapon
Copy link
Member

@ultimaweapon By the way, shouldn't relro and relro_size be stored inside a module too?

Only if we need to use it somewhere later.

@SuchAFuriousDeath
Copy link
Contributor Author

We do here, that's why I'm asking :D

@ultimaweapon
Copy link
Member

We do here, that's why I'm asking :D

Then the answer is yes.

@SuchAFuriousDeath SuchAFuriousDeath marked this pull request as ready for review April 2, 2024 22:51
@github-actions github-actions bot added the S-ready Status: Ready for review label Apr 2, 2024
mikusp
mikusp previously approved these changes Apr 5, 2024
View reviewed changes
src/kernel/src/rtld/module.rs Outdated Show resolved Hide resolved
mikusp
mikusp previously approved these changes Apr 5, 2024
View reviewed changes
VocalFan
VocalFan approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@VocalFan VocalFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't kill me for this lmao

@SuchAFuriousDeath SuchAFuriousDeath merged commit b741095 into obhq:main Apr 5, 2024
5 checks passed
@SuchAFuriousDeath SuchAFuriousDeath deleted the sys-593 branch April 5, 2024 21:05
@SuchAFuriousDeath SuchAFuriousDeath linked an issue Apr 5, 2024 that may be closed by this pull request
Resolve the difference between our 'ModuleFlags' and fpPS4's 'rtld_flags' #799
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VocalFan VocalFan VocalFan approved these changes

@mikusp mikusp mikusp left review comments

Assignees
No one assigned
Labels
S-ready Status: Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve the difference between our 'ModuleFlags' and fpPS4's 'rtld_flags' Implement sys_dynlib_get_info
4 participants
@SuchAFuriousDeath @ultimaweapon @mikusp @VocalFan