-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganizing 'specimen from organism' hierarchy #1839
Open
sebastianduesing
wants to merge
15
commits into
master
Choose a base branch
from
reorganize_specimens
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussed on the 2024-12-16 OBI dev call. Dan pointed out that 'digestive tract specimen' uses subClassOf axioms but should be an equivalent; Sebastian will go through the template and move other terms using subClassOf to be equivalent classes where applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1833. Reorganization of the 'specimen from organism' hierarchy in a way that groups specimens by body system. This first pass is a conservative reorganization, in which the only thing I've done is moved existing terms around, e.g., putting 'lower respiratory tract specimen' under 'respiratory system specimen'. This did significantly reduce the massive wall of un-organized specimen terms, but there's still a long, flat hierarchy of specimen terms remaining.
The next step would be to begin creating more grouped-by-system specimen terms, e.g., "digestive system specimen", "circulatory system specimen", "reproductive system specimen", etc. This will require some degree of adoption of Uberon hierarchies. Before I do that, we'll need to come to a decision on how we want to handle that, as is mentioned in the discussion thread of #1833.