Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyrights/licenses check was removed, probably by mistake #628

Open
yegor256 opened this issue Dec 12, 2024 · 5 comments
Open

copyrights/licenses check was removed, probably by mistake #628

yegor256 opened this issue Dec 12, 2024 · 5 comments
Assignees

Comments

@yegor256
Copy link
Member

#535 was closed, but copyrights.yml is not in .github/workflows any more. Any particular reason for disabling this check or it was removed by mistake?

@yegor256
Copy link
Member Author

yegor256 commented Dec 12, 2024

@deemp I see that now this check stays in ghc.yml. This looks a bit wrong, in my opinion. It's better to have separate jobs/files in CI, instead of one large job. Many smaller files will make build easier to understand for contributors: why it fails. @fizruk WDYT?

@deemp
Copy link
Member

deemp commented Dec 16, 2024

Many smaller files will make build easier to understand for contributors: why it fails.

@yegor256, we want to make contributors fix all problems discovered during static checks before running the tests and the pipeline. The most straightforward way to achieve this goal is to make the tests and pipeline jobs depend on the check job.

image

Usually, it's easy to discover the problem if one of the static checks fails.

Here, none of them has failed.

image

@yegor256
Copy link
Member Author

@deemp may I ask why?

we want to make contributors fix all problems discovered during static checks before running the tests and the pipeline.

@deemp deemp self-assigned this Dec 16, 2024
@deemp
Copy link
Member

deemp commented Dec 16, 2024

@yegor256, to maintain the code quality. Citing ChatGPT:

If static checks fail, there's no point in running tests. Running tests on code that has basic quality issues or linting violations would be a waste of CI resources, as the code is already in an unacceptable state. Running static checks first allows you to catch these issues early and avoid unnecessary test runs.

@yegor256
Copy link
Member Author

@deemp fair enough. Can you make jobs depend on each other while staying in different YAML files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants