Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work with desugared objects where appropriate #639

Open
deemp opened this issue Dec 17, 2024 · 0 comments
Open

Work with desugared objects where appropriate #639

deemp opened this issue Dec 17, 2024 · 0 comments

Comments

@deemp
Copy link
Member

deemp commented Dec 17, 2024 •
edited
Loading

Details

Currently, some functions desugar the input object:

eo-phi-normalizer/eo-phi-normalizer/src/Language/EO/Phi/Normalize.hs

Line 81 in eb8ca60

obj@ConstString{} -> peelObject (desugar obj)

It seems that we can desugar once after parsing since we don't need sugar during processing.

@fizruk, WDYT?

Subtasks

  • Create the Sugared a newtype
  • Create Desugarable a and Sugarable a type classes that will allow desugaring and sugaring of expressions
  • Update functions that call desugar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@deemp