Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnderlinedMessage.java:43-45: Add more decorators for the... #3756

Closed
0pdd opened this issue Dec 25, 2024 · 1 comment · Fixed by #3762
Closed

UnderlinedMessage.java:43-45: Add more decorators for the... #3756

0pdd opened this issue Dec 25, 2024 · 1 comment · Fixed by #3762
Assignees
@volodya-lombrozo
Labels
bug pdd

Comments

@0pdd
Copy link

0pdd commented Dec 25, 2024

The puzzle 3332-6fa7c070 from #3332 has to be resolved:

eo/eo-parser/src/main/java/org/eolang/parser/UnderlinedMessage.java

Lines 43 to 45 in 71e3409

* @todo #3332:30min Add more decorators for the error message.
* For example, {@link GeneralErrors} currently contains logic related to the message formatting.
* It's better to create a separate class for this purpose.

The puzzle was created by Yegor Bugayenko on 25-Dec-24.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Dec 25, 2024
@yegor256
Merge pull request #3751 from volodya-lombrozo/3742_errors
71e3409 
feat(#3742): Split `ParsingErrors` on Two Separate Classes
@0pdd 0pdd mentioned this issue Dec 25, 2024
Open
@volodya-lombrozo
Copy link
Member

@yegor256 I can work on this

volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Dec 25, 2024
@volodya-lombrozo
feat(objectionary#3756): remove the puzzle for objectionary#3756 issue
5bde75e
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Dec 25, 2024
@volodya-lombrozo
feat(objectionary#3756): add LocationMessage
e399d30
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Dec 25, 2024
@volodya-lombrozo
feat(objectionary#3756): use message classes in the production code
4e5f1f5
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Dec 25, 2024
@volodya-lombrozo
feat(objectionary#3756): fix test cases according with the new format…
76bf5a0 
…ting
@volodya-lombrozo volodya-lombrozo mentioned this issue Dec 25, 2024
Merged
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Dec 26, 2024
@volodya-lombrozo
feat(objectionary#3756): LocationMessage -> MsgLocated, UnderlinedMes…
829f334 
…sage -> MsgUnderlined
github-merge-queue bot pushed a commit that referenced this issue Dec 26, 2024
@yegor256
Merge pull request #3762 from volodya-lombrozo/3756_error_msgs
d5de9b0 
feat(#3756): Use a Single Format for All Error Messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volodya-lombrozo volodya-lombrozo

Labels
bug pdd
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#3756): Use a Single Format for All Error Messages volodya-lombrozo/eo
2 participants
@0pdd @volodya-lombrozo