Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SameXml.java:84-86: Avoid Using Public Static Method From... #348

Closed
0pdd opened this issue Jul 12, 2024 · 2 comments · Fixed by #351
Closed

SameXml.java:84-86: Avoid Using Public Static Method From... #348

0pdd opened this issue Jul 12, 2024 · 2 comments · Fixed by #351
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@0pdd
Copy link

0pdd commented Jul 12, 2024

The puzzle 329-939b7fc0 from #329 has to be resolved:

* @todo #329:30min Avoid Using Public Static Method From SameXml Class.
* I exposed this method to avoid the problem with XMIR comparision in {@link it.DetectiveIT}
* test. But it's much better to hide this static method and invent more OOP-suitable solution.

The puzzle was created by volodya-lombrozo on 12-Jul-24.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@h1alexbel
Copy link
Contributor

@volodya-lombrozo I can take it

@volodya-lombrozo volodya-lombrozo added bug Something isn't working good first issue Good for newcomers labels Jul 29, 2024
@volodya-lombrozo
Copy link
Member

@h1alexbel Please, go ahead!

h1alexbel added a commit to h1alexbel/opeo-maven-plugin that referenced this issue Jul 29, 2024
h1alexbel added a commit to h1alexbel/opeo-maven-plugin that referenced this issue Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants