Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap default service URLs #3

Open
andrus opened this issue May 2, 2016 · 3 comments
Open

Remap default service URLs #3

andrus opened this issue May 2, 2016 · 3 comments

Comments

@andrus
Copy link
Contributor

andrus commented May 2, 2016

New default servlet mappings:

  1. Remap jersey servlet for GraphQL from /* to /graphql-rest/ . Otherwise it may conflict with webconsole and other servlets.
  2. Remap webconsole URL /graphiql to /graphql-console . We are no longer using the term "graphiql".
@andrus andrus changed the title Remap web console from /graphiql to /graphql-console Remap web console from /graphiql to /graphql-ui May 2, 2016
@andrus andrus changed the title Remap web console from /graphiql to /graphql-ui Remap default service URLs May 2, 2016
@andrus
Copy link
Contributor Author

andrus commented May 2, 2016

To remap Jersey servlet we may need to add a feature to Bootique to change urlPatterns via config. So this is not immediately actionable.

avoitenkov added a commit that referenced this issue May 3, 2016
@andrus
Copy link
Contributor Author

andrus commented May 3, 2016

@avoitenkov The current solution is not ideal. Upstream JS code references /graphql-rest/ URL , but the URL itself is defined downstream in the examples config. Also in the future there may be more then one REST endpoint serving different GraphQL schemas.

We need to think how to make it easy and consistent. Perhaps do something like this:

  • make REST URL mapping to be a configuration property of graphql-bootique
  • make console URL mapping to a config property of graphql-webconsole
  • make graphql-webconsole dynamically detect where REST API is located and adjust JS accordingly.

So there's some design work to be done. Maybe for now we revert the 3f04879 commit and keep this task open?

@avoitenkov
Copy link
Contributor

the 3f04879 commit was reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants