-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dangling CARO term and CARO incompatibility with CL #1306
Comments
Suggested fixes: remove domain of innervates. # @shawntanzk to test this fix. |
see oborel/obo-relations#527 (comment) for the test on removing domain of innervates and using --unsatisfiable root |
We'll look this again after base migration. |
@shawntanzk to recheck if this is still a problem with basefile |
Does CARO import still => inconsistency? |
Not too sure, actually now that you mention, CARO is not importing cause it isn't declared, let me try fixing and see if there is still issues |
THese look like genuine errors that should be easy to fix
microfold cell of epithelium proper of appendix SubClassOf epithelium of appendix subClassOf -> part_of (some)
innervates -> 'has sensory dendrite in' http://purl.obolibrary.org/obo/RO_0013007 (see fbbt for precedents) Also - this should be fixed: |
Looks like it fixed it :) will make a PR. Thanks! |
Currently blocked by obophenotype/caro#23 |
made nerve plexus a subtype of anatomical junction, obophenotype/cell-ontology#1306
I don't see a PR for the simple changes @dosumis requested in #1306 (comment) |
@cmungall - I will check up on this |
Currently, there is a dangling CARO term (CARO_0010000) that is used by a RO term (directly develops from) that is used in UBERON term (equiv class for maxillary artery) that used by another uberon term (deep auricular artery) that isn't used by any term except itself (I think).
I tried to solve the dangling term by doing and import of that CARO term, however when trying to test a release, CARO seems to be incompatible with CL -> error saying that there are unsatisfiable classes.
I'm not sure if it would be sensible, or for that matter how to, remove some terms in the uberon import?
I'm also not sure if it is an issue that CARO isn't compatible with CL and do we have to chase down a reason?
Or if it's just not worth it and we just leave the dangling term?
Related to obophenotype/uberon#1963
The text was updated successfully, but these errors were encountered: