Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangling CARO term and CARO incompatibility with CL #1306

Closed
shawntanzk opened this issue Nov 11, 2021 · 16 comments · Fixed by #1559
Closed

Dangling CARO term and CARO incompatibility with CL #1306

shawntanzk opened this issue Nov 11, 2021 · 16 comments · Fixed by #1559
Assignees

Comments

@shawntanzk
Copy link
Contributor

Currently, there is a dangling CARO term (CARO_0010000) that is used by a RO term (directly develops from) that is used in UBERON term (equiv class for maxillary artery) that used by another uberon term (deep auricular artery) that isn't used by any term except itself (I think).
I tried to solve the dangling term by doing and import of that CARO term, however when trying to test a release, CARO seems to be incompatible with CL -> error saying that there are unsatisfiable classes.
I'm not sure if it would be sensible, or for that matter how to, remove some terms in the uberon import?
I'm also not sure if it is an issue that CARO isn't compatible with CL and do we have to chase down a reason?
Or if it's just not worth it and we just leave the dangling term?
Related to obophenotype/uberon#1963

@shawntanzk shawntanzk self-assigned this Nov 11, 2021
@shawntanzk
Copy link
Contributor Author

latissimus dorsi muscle SubClassOf Nothing

sciatic nerve SubClassOf Nothing

vomeronasal sensory neuron SubClassOf Nothing

serratus ventralis SubClassOf Nothing

tibial nerve SubClassOf Nothing

microfold cell of epithelium proper of appendix SubClassOf Nothing

deltoid SubClassOf Nothing

brachial nerve plexus SubClassOf Nothing

axillary nerve SubClassOf Nothing

lumbosacral nerve plexus SubClassOf Nothing

Axiom Impact

Axioms used 9 times

Axioms used 8 times

Axioms used 5 times

Axioms used 4 times

Axioms used 3 times

Axioms used 2 times

Axioms used 1 times

Ontologies used:

@shawntanzk
Copy link
Contributor Author

@cmungall @balhoff @dosumis - Could you help me with the above please? Thanks!

@dosumis
Copy link
Contributor

dosumis commented Nov 22, 2021

  • multicellular anatomical structure EquivalentTo connected anatomical structure and (has characteristic some multicellular)

  • multi-cell-part structure DisjointWith multicellular anatomical structure

  • innervates Domain neuron projection bundle

  • neuron projection bundle SubClassOf multi-cell-part structure

  • nerve plexus SubClassOf neural tissue

  • neural tissue EquivalentTo tissue and (has_part some glial cell) and (has_part some neuron)

Suggested fixes: remove domain of innervates. # @shawntanzk to test this fix.

@shawntanzk
Copy link
Contributor Author

see oborel/obo-relations#527 (comment) for the test on removing domain of innervates and using --unsatisfiable root

@dosumis
Copy link
Contributor

dosumis commented Nov 23, 2021

@anitacaron
Copy link
Contributor

We'll look this again after base migration.

@shawntanzk
Copy link
Contributor Author

@shawntanzk to recheck if this is still a problem with basefile

@shawntanzk
Copy link
Contributor Author

Currently the following are dangling:

Screenshot 2022-01-10 at 14 40 36

Not 100% sure how to handle these with base file merge imports, until then, can't see if CARO imports will cause issues

@dosumis
Copy link
Contributor

dosumis commented Jan 13, 2022

Does CARO import still => inconsistency?

@shawntanzk
Copy link
Contributor Author

Does CARO import still => inconsistency?

Not too sure, actually now that you mention, CARO is not importing cause it isn't declared, let me try fixing and see if there is still issues

@shawntanzk
Copy link
Contributor Author

Yup there still are incompatibilities:

microfold cell of epithelium proper of appendix SubClassOf Nothing

vomeronasal sensory neuron SubClassOf Nothing

Axiom Impact

Axioms used 2 times

Axioms used 1 times

Ontologies used:

@dosumis
Copy link
Contributor

dosumis commented Jan 13, 2022

THese look like genuine errors that should be easy to fix

  1. A cell is not an epithelium:

microfold cell of epithelium proper of appendix SubClassOf epithelium of appendix

subClassOf -> part_of (some)

  1. vomeronasal sensory neuron EquivalentTo sensory neuron and (part_of some vomeronasal organ) and (innervates some epithelium of vomeronasal organ)

innervates -> 'has sensory dendrite in' http://purl.obolibrary.org/obo/RO_0013007 (see fbbt for precedents)

Also - this should be fixed:
part_of -> has_soma_location

image
[https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5947554/]

@shawntanzk
Copy link
Contributor Author

Looks like it fixed it :) will make a PR. Thanks!

@shawntanzk
Copy link
Contributor Author

Currently blocked by obophenotype/caro#23

nicolevasilevsky added a commit to obophenotype/uberon that referenced this issue Jan 24, 2022
@cmungall
Copy link
Member

I don't see a PR for the simple changes @dosumis requested in #1306 (comment)

@shawntanzk
Copy link
Contributor Author

@cmungall - I will check up on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants