-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate HCA bionetwork draft PBMC heirarchy #1912
Comments
I have generated a CT table based on the PBMC hierarchy generated by @amcujba. All cells could be mapped except two:
@amcujba, are these two cells missing in CL ontology? |
Thank you, @aleixpuigb! When using the python lib
|
Thanks! I have it in this format now. I will save it as .csv and try run it. |
This is the output of the relation-validator:
These are the proposed fixes for the relations:
|
Hi, thanks for this @aleixpuigb and @anitacaron. I can double check these changes with the immune bionetwork and get back to you. I believe David will be attending the meeting tomorrow at 2pm, so we can take it from there as well. |
Hi @amcujba, based on the proposed changes to validate, I have generated an updated hierarchy. The green cells are the edits (cell has been moved or a term has been added). I am available if you would like to discuss it in person or in a call. |
Hi @aleixpuigb. Please send me your email addresses and I will invite you to our immune bionetwork meeting, where you can share the hierarchy. I can also share it with them before the meeting, if that is okay with you. Thank you. |
Hi @amcujba, no problem at all, you can share it. My email address is [email protected]. Thanks! |
Hi @dosumis, can this ticket be closed as completed? |
I have cc'd you in the email to the immune bionetwork, Aleix, apologies for
the delay.
…On Tue, Jul 18, 2023 at 3:21 PM Aleix Puig ***@***.***> wrote:
Hi @dosumis <https://github.com/dosumis>, can this ticket be closed as
completed?
—
Reply to this email directly, view it on GitHub
<#1912 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUYJ4XTDVPMDB5FTQ6GUAIDXQ2LU7ANCNFSM6AAAAAAWKFVMLY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @amcujba, can this ticket be closed as completed? Thank you. |
Hi @amcujba, I will close this ticket as completed. Feel free to reopen it if there's something else needed. Thank you. |
Hi @amcujba, I am writing to you because we are preparing a manuscript about the validation tool that we used to validate the HCA hierarchy in this ticket. The manuscript will be focused mainly on how this tool was built to validate the ASCT+B tables from HuBMAP, but it would be very beneficial if we could provide more use cases. I was wondering if you would be ok that we use the validation of the HCA hierarchy as a use case. Thank you! |
Hello Aleix,
Could you please contact me via ***@***.***? I do not always check
this email, apologies for the late reply. What would you need me to
provide? more unmatching labels? thank you!
…On Fri, Mar 1, 2024 at 3:44 PM Aleix Puig ***@***.***> wrote:
Hi @amcujba <https://github.com/amcujba>,
I am writing to you because we are preparing a manuscript about the
validation tool that we used to validate the HCA hierarchy in this ticket.
The manuscript will be focused mainly on how this tool was built to
validate the ASCT+B tables from HuBMAP, but it would be very beneficial if
we could provide more use cases. I was wondering if you would be ok that we
use the validation of the HCA hierarchy as a use case. Thank you!
—
Reply to this email directly, view it on GitHub
<#1912 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUYJ4XTSV6WMST6U5CEJLBTYWCH6NAVCNFSM6AAAAAAWKFVML2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZTGMZDONZTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Aim here is to validate the draft PBMC hierarchy generated by @amcujba for the blood cell type reconciliation effort of the HCA
To do this we need to convert the hierarchy into a standard validation table with IDs. Validation can then be carried out using @anitacaron 's https://pypi.org/project/relation-validator/ lib. The current hierarchy has only labels (although these should align with CL labels), so an initial mapping is needed (manual or semi-automated).
Suggested division of work:
The text was updated successfully, but these errors were encountered: