Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate HCA bionetwork draft PBMC heirarchy #1912

Closed
2 tasks done
Tracked by #1798
dosumis opened this issue Mar 28, 2023 · 14 comments
Closed
2 tasks done
Tracked by #1798

Validate HCA bionetwork draft PBMC heirarchy #1912

dosumis opened this issue Mar 28, 2023 · 14 comments
Assignees

Comments

@dosumis
Copy link
Contributor

dosumis commented Mar 28, 2023

Aim here is to validate the draft PBMC hierarchy generated by @amcujba for the blood cell type reconciliation effort of the HCA

To do this we need to convert the hierarchy into a standard validation table with IDs. Validation can then be carried out using @anitacaron 's https://pypi.org/project/relation-validator/ lib. The current hierarchy has only labels (although these should align with CL labels), so an initial mapping is needed (manual or semi-automated).

Suggested division of work:

@aleixpuigb
Copy link
Collaborator

I have generated a CT table based on the PBMC hierarchy generated by @amcujba. All cells could be mapped except two:

  • progenitor (parent term innate lymphoid cell). There is an immature innate lymphoid cell, but it is not a progenitor.
  • IGA.IGL (parent term plasma cell)

@amcujba, are these two cells missing in CL ontology?
@anitacaron, can you use this table for validation? I have used the same format from ASCT+B tables, but let me know if you need a different format.

@anitacaron
Copy link
Contributor

anitacaron commented May 12, 2023

Thank you, @aleixpuigb! When using the python lib relation-validator, we need a more straightforward table with the columns:

s slabel user_slabel o olabel user_olabel
the subject term ID the label of the term in the column s optional label for the term given by user the object term ID the label of the term in the column s optional label for the term given by user

@aleixpuigb
Copy link
Collaborator

aleixpuigb commented May 12, 2023

Thanks! I have it in this format now. I will save it as .csv and try run it.

@aleixpuigb
Copy link
Collaborator

aleixpuigb commented May 18, 2023

This is the output of the relation-validator:

s slabel user_slabel o olabel user_olabel
CL:0000050 megakaryocyte-erythroid progenitor cell megakaryocyte-erythroid progenitor cell CL:0000556 megakaryocyte megakaryocyte
CL:0000233 platelet platelet CL:0000556 megakaryocyte megakaryocyte
CL:0000798 gamma-delta T cell gamma-delta T cell CL:0000789 alpha-beta T cell alpha-beta T cell
CL:0000786 plasma cell plasma cell CL:0000785 mature B cell mature B cell
CL:0000813 memory T cell memory alpha-beta T cell (memory T cell?) CL:0000791 mature alpha-beta T cell mature alpha-beta T cell
CL:0000898 naive T cell naive T cell CL:0000791 mature alpha-beta T cell mature alpha-beta T cell
CL:0000815 regulatory T cell regulatory T cell CL:0000791 mature alpha-beta T cell mature alpha-beta T cell

These are the proposed fixes for the relations:

image

@amcujba
Copy link

amcujba commented May 18, 2023

Hi, thanks for this @aleixpuigb and @anitacaron. I can double check these changes with the immune bionetwork and get back to you. I believe David will be attending the meeting tomorrow at 2pm, so we can take it from there as well.

@aleixpuigb
Copy link
Collaborator

Hi @amcujba, based on the proposed changes to validate, I have generated an updated hierarchy. The green cells are the edits (cell has been moved or a term has been added). I am available if you would like to discuss it in person or in a call.

@amcujba
Copy link

amcujba commented May 19, 2023

Hi @aleixpuigb. Please send me your email addresses and I will invite you to our immune bionetwork meeting, where you can share the hierarchy. I can also share it with them before the meeting, if that is okay with you. Thank you.

@aleixpuigb
Copy link
Collaborator

Hi @amcujba, no problem at all, you can share it. My email address is [email protected]. Thanks!

@aleixpuigb
Copy link
Collaborator

Hi @dosumis, can this ticket be closed as completed?

@amcujba
Copy link

amcujba commented Jul 18, 2023 via email

@aleixpuigb
Copy link
Collaborator

Hi @amcujba, can this ticket be closed as completed? Thank you.

@aleixpuigb
Copy link
Collaborator

Hi @amcujba, I will close this ticket as completed. Feel free to reopen it if there's something else needed. Thank you.

@aleixpuigb
Copy link
Collaborator

Hi @amcujba,

I am writing to you because we are preparing a manuscript about the validation tool that we used to validate the HCA hierarchy in this ticket. The manuscript will be focused mainly on how this tool was built to validate the ASCT+B tables from HuBMAP, but it would be very beneficial if we could provide more use cases. I was wondering if you would be ok that we use the validation of the HCA hierarchy as a use case. Thank you!

@amcujba
Copy link

amcujba commented Mar 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants