Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #2219 Revise logical definition for 'kidney collecting duct… #2220

Merged
1 commit merged into from
Nov 15, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 15, 2023

Addresses #2219 Revise logical definition for 'kidney collecting duct epithelial cell'

@ghost ghost self-assigned this Nov 15, 2023
@ghost ghost linked an issue Nov 15, 2023 that may be closed by this pull request
@ghost
Copy link
Author

ghost commented Nov 15, 2023

#gogoeditdiff

Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-11-15/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-11-15/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

kidney cortex collecting duct epithelial cell http://purl.obolibrary.org/obo/CL_1000549

Removed

Added

kidney medulla collecting duct epithelial cell http://purl.obolibrary.org/obo/CL_1000546

Removed

Added

Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

kidney collecting duct epithelial cell http://purl.obolibrary.org/obo/CL_1000454

Removed

Added

@ghost ghost requested a review from aleixpuigb November 15, 2023 08:52
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No breaking changes noted.

@ghost ghost merged commit 06f98c7 into master Nov 15, 2023
1 check passed
@ghost ghost deleted the 2219-edit_logical_def_kidney_collect_duct_epi_cell branch November 15, 2023 10:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise logical definition for 'kidney collecting duct epithelial cell'
1 participant