Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated mappings to be removed #2233

Closed
gouttegd opened this issue Nov 22, 2023 · 0 comments · Fixed by #2236
Closed

Duplicated mappings to be removed #2233

gouttegd opened this issue Nov 22, 2023 · 0 comments · Fixed by #2236
Assignees

Comments

@gouttegd
Copy link
Collaborator

CL contains a handful of duplicated cross-references to FMA and MA, where two (or more) CL terms point to the same foreign term. Cross-references to FMA and MA are intended to be “exact matches” (modulo the taxon specificity), so any such instance of duplicated cross-references is almost certainly bogus.

Foreign term CL terms Proposed resolution Confidence in resolution Comment
FMA:18690 CL:0000503 CL:0000590 Remove xref on CL:0000503 0.8 Based on synonym and hierarchy, CL:0000590 is correct
FMA:54540 CL:0000128 CL:0000129 Remove xref on CL:0000129 1 Mapping with “microglial cell” looks like a plain error
FMA:62125 CL:0002305 CL:0002306 Remove all xrefs 1 Both mappings are bogus: the FMA term is about the epithelium, not any epithelial cell
FMA:62364 CL:0000202 CL:4023120 Remove xref on CL:0000202 0.5 CL:4023120 is probably correct, but it seems FMA has no concept of hair cell elsewhere than in the cochlea
FMA:63207 CL:0002268 CL:0002501 Remove xref on CL:0002268 0.8 FMA term is specifically about type D1
FMA:63368 CL:0000034 CL:0000723 Remove xref on CL:0000723 0.8 FMA term says nothing about a restriction to “somatic”
FMA:70573 CL:0000794 CL:0000910 Remove xref on CL:0000794 0.5 CL:0000794 seems way too specific
FMA:74505 CL:0002660 CL:0002662 Remove xref on CL:0002662 0.8 CL:0002660 is a closer match
FMA:75722 CL:0002163 CL:1000191 Remove xref on CL:0002163 0.8 FMA term does not precise “internal” or “external”
FMA:82841 CL:0002321 CL:0002322 Remove xref on CL:0002321 0.8 FMA term is specifically about a stem cell, not any embryonic cell
FMA:83885 CL:1000481 UBERON:0005351 Remove xref on CL:1000481 0.8 CL term has seemingly nothing to do with a “paraflocculus”
FMA:84448 CL:0000189 CL:0002210 Remove xref on CL:0000189 0.8 FMA term is specifically about a “red” muscle cell
FMA:86475 CL:0000037 CL:0001024 Remove xref on CL:0001024 0.8 CL:0001024 seems way too specific
MA:0000388 CL:0000021 CL:0000025 Remove xref on CL:0000025 0.8 MA:0000388 and CL:0000021 are both “female germ cell” while CL:0000025 is “egg cell”

Note: This is a wider issue that affects both Uberon and CL, and needs to be fixed in both ontologies. I created this ticket only to have an issue number to refer to when I’ll fix the duplicates in CL. If you have comments on those duplicates or the proposed resolution, I’d appreciate if you keep the discussion on the original Uberon ticket rather than here.

@gouttegd gouttegd self-assigned this Nov 22, 2023
gouttegd added a commit that referenced this issue Nov 27, 2023
This commit removes all the duplicated cross-references to FMA and MA
terms listed in #2233. The presence of such duplicated cross-references
1) is abnormal since cross-references to FMA and MA are supposed to be
"exact" and 2) interferes with the generation of the CL bridges in
Uberon.

closes #2233
gouttegd added a commit that referenced this issue Dec 5, 2023
This commit removes all the duplicated cross-references to FMA and MA
terms listed in #2233. The presence of such duplicated cross-references
1) is abnormal since cross-references to FMA and MA are supposed to be
"exact" and 2) interferes with the generation of the CL bridges in
Uberon.

closes #2233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant