Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the need for issues/contributor.owl #3453

Open
gouttegd opened this issue Dec 18, 2024 · 0 comments
Open

Review the need for issues/contributor.owl #3453

gouttegd opened this issue Dec 18, 2024 · 0 comments
Labels

Comments

@gouttegd
Copy link
Collaborator

gouttegd commented Dec 18, 2024

One of the custom steps in the Uberon pipeline is the merging of the issue/contributor.owl file into the ontology.

That file is supposed to contain “contributor“ annotations that are automatically generated based on GitHub activity: basically, a GitHub user is added as a “contributor“ to a term if that user has been involved in the discussion(s) pertaining to that term (e.g. has posted a comment in the issue where the term was requested).

There are several problems with that step:

(1) The process that generates the issue/contributor.owl file relies on tools that are not available in the ODK (blip-findall, tbl2p) and presumably not even supported anymore. Consequently, that file has not been updated at least since the ODK migration, three years ago.

(2) The file is using the http://purl.org/dc/elements/1.1/contributor annotation property, which is explicitly banned in the rest of Uberon. The continued use of that property escapes the detection by the illegal-annotation-property-violation.sparql check because the issue/contributor.owl file is not merged at the time the check occurs.

(3) Contributors are identified by the URL of their GitHub profile, which is better than nothing I guess but ORCIDs would be preferable.

I question the overall need for such a step. Trying to mention all the persons who participated in the discussion about a term as contributors of that term is noble, but I am not convinced it is worth the added complexity.

I propose to (A) transfer the existing annotations in issue/contributor.owl to the -edit file (and while doing that, switching them to the http://purl.org/dc/terms/contributor property, and replacing the GitHub profile URLs by ORCIDs whenever possible) and (B) get rid of issue/contributor.owl and all the associated code entirely.

(B) Alternatively, if really mentioning all the persons who participated in a discussion about a term as contributors to that term is deemed important, then the code that generates the issue/contributor.owl needs to be thoroughly modernised so that the file can be updated again.

@gouttegd gouttegd added the tech label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant